618932 - FieldDoesNotExist: Addon has no field named 'has_eula'

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[krupa raj[:krupa]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13

steps to reproduce:
1. Upload an add-on @ https://addons.allizom.org/z/en-US/developers/addon/submit/1
2. Provide the relevant information required in step 2,3 and 4
3. In step 5, pick a license and check both the policy options without entering any content in the policy-description field.
4. Click "continue"

traceback details:
le "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 24, in wrapper
   return func(request, *args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/devhub/views.py", line 52, in wrapper
   return fun()

 File "/data/amo_python/www/preview/zamboni/apps/devhub/views.py", line 48, in <lambda>
   fun = lambda: f(request, addon_id=addon_id, addon=addon, *args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/devhub/views.py", line 644, in wrapper
   return f(request, *args, **kw)

 File "/data/amo_python/www/preview/zamboni/apps/devhub/views.py", line 732, in submit_license
   _policy_form(request, addon, save=True)

 File "/data/amo_python/www/preview/zamboni/apps/devhub/views.py", line 318, in _policy_form
   policy_form.save()

 File "/data/amo_python/www/preview/zamboni/apps/devhub/forms.py", line 164, in save
   if not self.changed_data:

 File "/data/amo_python/www/preview/zamboni/apps/amo/forms.py", line 42, in _get_changed_data
   for name in changed]

 File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/db/models/options.py", line 279, in get_field
   raise FieldDoesNotExist('%s has no field named %r' % (self.object_name, name))

FieldDoesNotExist: Addon has no field named 'has_eula'


<WSGIRequest
GET:<QueryDict: {}>,
POST:<QueryDict: {u'eula': [u''], u'name': [u'Custom License'], u'text': [u''], u'has_eula': [u'on'], u'builtin': [u'3'], u'privacy_policy': [u'kjhkj'], u'has_priv': [u'on'], u'csrfmiddlewaretoken': [u'b7b27e8a259c8d407ce377eb127b0b10']}>,

Comment 1

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commit/79396ec

Comment 2

[krupa raj[:krupa]]

No traceback on submitting an add-on with an empty EULA anymore. Marking this verified.