618957 - [mozprofile] Multiple Item Packaged extensions are not correctly handled

Status: RESOLVED WONTFIX

(Testing :: Mozbase, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Add-ons that use Multiple Item Packaging (https://developer.mozilla.org/en/Multiple_Item_Packaging) are not being correctly handled correctly by Mozmill.

An example of this is the later releases of Selenium IDE, one of which can be found here: http://release.seleniumhq.org/selenium-ide/1.0.10/selenium-ide-1.0.10.xpi

Steps to reproduce:
1. Launch Mozmill via the command line interface, specifying Selenium IDE add-on version 1.0.10 (available at the above URL)

Expected:
In the launched Firefox instance, item 'Selenium IDE' should be available from the 'Tools' menu.

Actual:
Selenium IDE is not present in the Tools menu. In the profile, the various xpi files are present and have not been extracted as expected for this add-on.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

The problems are not only related to muli-packages XPI's, but also to some extensions we fail on because we wrongly parse the install.rdf, i.e. Console2 (see bug 602284 comment 6).

Dave, what would be the best way for an external tool to install extensions into the users profile? We would need something better as:

https://github.com/mozautomation/mozmill/blob/master/mozprofile/mozprofile/profile.py#L98

Comment 2

[Dave Townsend [:mossop]]

(In reply to comment #1)
> The problems are not only related to muli-packages XPI's, but also to some
> extensions we fail on because we wrongly parse the install.rdf, i.e. Console2
> (see bug 602284 comment 6).
> 
> Dave, what would be the best way for an external tool to install extensions
> into the users profile? We would need something better as:
> 
> https://github.com/mozautomation/mozmill/blob/master/mozprofile/mozprofile/profile.py#L98

Do you mean at runtime or at startup. For the former you'd be best off using the AddonManager.getInstallForFile method and APIs to install them but then you'd have to restart the app. At startup the only way really is to extract the XPI's into their correctly named directories in the profile.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

(In reply to comment #2)
> Do you mean at runtime or at startup. For the former you'd be best off using
> the AddonManager.getInstallForFile method and APIs to install them but then
> you'd have to restart the app. At startup the only way really is to extract the
> XPI's into their correctly named directories in the profile.

It's always during start-up for Mozmill. Given your answer we would still have to parse the install.rdf for the extension id, so we can correctly set the name of the XPI or folder. That means we have to be more clever in parsing that file.

For the multi-packaged case we have to be even more clever.

Comment 4

[cmtalbert]

I don't see any compelling case for doing this on 1.5.2. It's been this way a long time, and this is the first bug reported about it.  I think I'm going to minus on this for 1.5.2.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Dave, it doesn't stop our ongoing efforts to run Mozmill tests for the Selenium IDE, right? There is still a separate package for it we can use?

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Henrik: That's correct. Ultimately I would like to use the multi-xpi but for now we can use the core XPI that is packaged within the multi-xpi.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Thanks Dave. In that case and our ongoing efforts for add-on tests, I would really like to see a fix for 2.0 if possible. There are some more add-ons out there which are packaged that way.

Comment 8

[cmtalbert]

This is definitely desired for 2.0, but I wouldn't hold the release for it.  We've got a lot more important issues to solve for 2.0 first, and frankly there aren't that many of these multi-addons out there.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

This is more a bug in mozprofile than Mozmill. Moving to the correct component.

Comment 10

[Geoff Brown [:gbrown]]

Mass closing bugs with no activity in 2+ years. If this bug is important to you, please re-open.