618977 - Specifying an invalid test-path no longer complains about no tests to run, instead just does nothing

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Dave Townsend [:mossop]]

If you give a test-path that doesn't include any tests (f.e. if you typo a test name) then clicking run tests switches to the browser window and then nothing happens. The error console displays:

Error: linkArray is undefined
Source File: chrome://mochikit/content/server.js
Line: 555

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I guess this must have been broken by bug 592859 (http://hg.mozilla.org/mozilla-central/rev/f9fcf102493f )

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: display an error in the log/console if the --test-path is incorrect for browsr-chrome (1.0)

simple fix to display an no tests found when specifying a --test-path for browser-chrome.  This fix also will work for mochitest and mochitest-chrome since they use the same functions.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

this is passing on try server.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: unbitrotted patch

I updated the patch to current trunk and made a minor tweak. Joel, do you want to land this or shall I?

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

I can land this tomorrow morning on m-c, but feel free to land this earlier if you have other patches landing.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/mozilla-central/rev/a365ca6c2379

Comment 7

[Jonathan Protzenko [:protz]]

I just had this very issue (linkArray is undefined) because I hadn't updated the Makefile.in and ran make -C dom/tests/mochitest/chrome to make sure the test file was copied in my objdir. My copy of m-c is fresh from a couple days ago. Should I file a new bug or reopen this one?