618992 - services.sync.log.appender.debugLog.enabled should be on for nightlies

Status: NEW

(Firefox :: Sync, defect)

Description

[LegNeato]

services.sync.log.appender.debugLog.enabled should be on for nightlies. If we are concerned about disk IO, we can turn it off for every beta and release. I think by default testers should have access to that data to better track down transient issues.

Comment 1

[:Atoll]

The lack of debug logs by default in nightlies has an unexpected impact on Services Ops.  Each time something breaks in the client, folks ask us "Is production down?".  Most of the time, that isn't the issue, and we have to somehow reproduce their problem.  This is especially problematic with transient wifi issues and upgrade issues.  Therefore I'm raising this to CRITICAL; every day we wait to push this into nightlies, we lose valuable information that might help us find and/or fix potential sync blocker bugs.

Comment 2

[LegNeato]

Pushing it over to mconnor, feel free to reassign.

Comment 3

[:Atoll]

mconnor is unavailable for 2 weeks, who else can review this?

Comment 4

[Philipp von Weitershausen [:philikon]]

I don't think we want to temporarily flip the pref and then flip it back before each release because that way lies madness.

There are ways to programmatically determine whether we're on a release build or not

a. inspect the "app.update.channel" pref [1]
b. ifdef MOZ_OFFICIAL_BRANDING [2]

Option a. would probably be best applied in Service._initLogs(), option b. could be applied as a preprocessor rule in services-sync.js.

Thoughts? Preferences?

[1] https://mxr.mozilla.org/mozilla-central/source/toolkit/content/debug.js#70
[2] https://mxr.mozilla.org/mozilla-central/source/toolkit/components/search/nsSearchService.js#151

Comment 5

[LegNeato]

I'd prefer b, as there has been some discussion about possibly changing the channel names in the future.

Comment 6

[Richard Newman [:rnewman]]

Guessing this wasn't actually critical, though I agree that it would still be nice to have...