619019 - Use -moz-device-orientation when needed

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

We added a CSS media query called -moz-device-orientation so we could track orientation based on device screen aspect, instead of the window aspect.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This adds some basic support for the new -moz-device-orientation

It also fixes Utils.isPortrait

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 497519 [details] [diff] [review]
patch

requesting review for this part. we can file a followup bug for setting other parts of the UI based on orientation or width.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/d1ce93590d43

Comment 4

[Anna (Waverley)]

Can someone, please, verify this bug?

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified : 

FYI, can test under the Device Access category -> Device Orientation:
https://mozillademos.org/demos/dashboard-mobile/demo.html

Mozilla/5.0 (Android; Linux armv71; rv7.0a1) Gecko/20110527 Firefox/7.0a1 Fennec/7.0a1
Device: Thunderbolt
OS: Android 2.2

Mozilla/5.0 (Android; Linux armv71; rv7.0a1) Gecko/20110527 Firefox/7.0a1 Fennec/7.0a1
Device: HTC Flyer
OS: Android 2.3