Use -moz-device-orientation when needed

VERIFIED FIXED

Status

VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

Trunk
x86
macOS

Details

Attachments

(1 attachment)

We added a CSS media query called -moz-device-orientation so we could track orientation based on device screen aspect, instead of the window aspect.
Created attachment 497519 [details] [diff] [review]
patch

This adds some basic support for the new -moz-device-orientation

It also fixes Utils.isPortrait
Assignee: nobody → mark.finkle
Attachment #497519 - Flags: feedback?(mbrubeck)
Attachment #497519 - Flags: feedback?(mbrubeck) → feedback+
Comment on attachment 497519 [details] [diff] [review]
patch

requesting review for this part. we can file a followup bug for setting other parts of the UI based on orientation or width.
Attachment #497519 - Attachment description: wip → patch
Attachment #497519 - Flags: review?
Attachment #497519 - Flags: review? → review?(mbrubeck)
Attachment #497519 - Flags: review?(mbrubeck) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/d1ce93590d43
Status: NEW → RESOLVED
tracking-fennec: --- → 2.0b4+
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 4

8 years ago
Can someone, please, verify this bug?
Verified : 

FYI, can test under the Device Access category -> Device Orientation:
https://mozillademos.org/demos/dashboard-mobile/demo.html

Mozilla/5.0 (Android; Linux armv71; rv7.0a1) Gecko/20110527 Firefox/7.0a1 Fennec/7.0a1
Device: Thunderbolt
OS: Android 2.2

Mozilla/5.0 (Android; Linux armv71; rv7.0a1) Gecko/20110527 Firefox/7.0a1 Fennec/7.0a1
Device: HTC Flyer
OS: Android 2.3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.