619052 - Unable to do a blank search in new Search field in Firefox 4

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Search, defect)

Description

[Pratibha]

Attachment: screenshot displays the message "Please fill out this field."

Steps:
=========
Installed FF Version: 4.0 Beta7
Build identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b7) Gecko/20100101 Firefox/4.0b7

-Launch FF4.0b7
-Open the page: https://addons-next.allizom.org/en-US/firefox/?browse=featured
-In Search field: Click on Go button without entering any text

Expected Result: A blank search is successful

Actual Result: A message comes up saying "Please fill out this field"

Note:
Tested with other versions:
3.6.13 : Works fine
4.0 Beta 6: Works fine
4.0 Beta 7: Fails as above

Comment 1

[Jeff Balogh (:jbalogh)]

HTML5 forms ftw.  fligtar: how do you feel about this?

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

FWIW, blank searches are usually people not using our search correctly.  This *should* be the expected behavior.

Comment 3

[Justin Scott [:fligtar]]

I don't see a reason to change search's behavior from how it currently works. We have over 50,000 searches a day without terms entered and in this new format you also can't drill down using the facets without entering search terms.

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Why would you search for nothing with or without facets?

Comment 6

[patrickjdempsey]

Is there any chance of getting this fixed?  The primary usefulness of this was to be able to search for ALL addons meeting certain conditions without knowing their names.  For example, try this in Firefox 3.5:

- blank search ->
- Press Themes
- Press 5.0
- Press MacOSX

Now you have a list of all of the themes available for Firefox 5.0 for Mac... which is a significantly smaller number than the total theme list.  Maybe there should be a way to offer this feature in some other fashion, but this was the method that many people on forums tell people to use to find addons for specific Firefox versions or platforms.

Comment 7

[krupa raj[:krupa]]

Comment 6 is a good usecase for why we should consider supporting blank search. We should allow users who are browsing for add-ons of interest. Assigning to cvan as per his request.

Comment 8

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/69ad9da

Comment 9

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/32b82b0

Comment 10

[Pratibha]

verified fixed at:
https://addons-dev.allizom.org/en-US/firefox/search/?q=&cat=all&appver=7.0.1&platform=windows

Able to run a blank search 

postfix screencast: http://tinyurl.com/bqedq24