Closed Bug 619109 Opened 10 years ago Closed 4 years ago

Make document.write() insert into the right place when invoked from script@onload or from a script-inserted inline script when a parser-inserted script is on the call stack

Categories

(Core :: DOM: HTML Parser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

()

Details

Attachments

(1 file, 2 obsolete files)

Spun off of bug 592656:

document.write() insertion point tracking uses the current script from
nsScriptLoader. It should instead use the current parser-inserted script which
should get unset only after onload for the script has fired.

Attachment 486875 [details] [diff] has a fix.
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Attachment #497530 - Flags: review?(jonas)
sicking, any plans to bring this up at with Hixie and Adam now that Firefox 4 has shipped?
Comment on attachment 497530 [details] [diff] [review]
Define the insertion point before and undefine after the synchronous script execution events

Review of attachment 497530 [details] [diff] [review]:
-----------------------------------------------------------------

Unassigning myself. I still think this is the wrong thing to do, but won't have time to chase the spec.

Please do what you think is right. If we still indeed want to make changes here any DOM peer should be able to review.
Attachment #497530 - Flags: review?(jonas)
Attachment #8786728 - Attachment description: Define the insertion point before and undefine after the synchronous script execution events, rebasedonload → Define the insertion point before and undefine after the synchronous script execution events, rebased
Comment on attachment 8786728 [details] [diff] [review]
Define the insertion point before and undefine after the synchronous script execution events, rebased

r=me assuming we're ok with before/afterscriptexecute having an insertion point defined.
Attached patch Rebased on top of (obsolete) — Splinter Review
Attachment #8786950 - Flags: review?(hsivonen)
Assignee: hsivonen → bzbarsky
Gah.  bzexport fail....
Assignee: bzbarsky → hsivonen
Attachment #8786950 - Attachment is obsolete: true
Attachment #8786950 - Flags: review?(hsivonen)
Attachment #497530 - Attachment is obsolete: true
Attachment #8786728 - Flags: review?(bzbarsky)
Comment on attachment 8786728 [details] [diff] [review]
Define the insertion point before and undefine after the synchronous script execution events, rebased

r=me
Attachment #8786728 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b722968c9d4c02152b787c70782971586b6c0fd
Bug 619109 - Define the insertion point before and undefine after the synchronous script execution events. r=bzbarsky.
https://hg.mozilla.org/mozilla-central/rev/3b722968c9d4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.