Closed Bug 619131 Opened 13 years ago Closed 13 years ago

Fix JS_SHARED_LIBRARY setting in comm-central for non-libxul builds (aka fix Calendar/Lightning link errors)

Categories

(MailNews Core :: Build Config, defect)

Product:
MailNews Core
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.3a2

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

The fix
1.81 KB, patch
Callek
: review+
Details | Diff | Splinter Review
Attached patch The fix — — Splinter Review 
I noticed this the other day when trying to build Lightning against Thunderbird trunk in a non-libxul configuration.

The basic error that is happening is that in configure.in we're trying to work out if to set ENABLE_SHARED_JS=1 (and subsequently JS_SHARED_LIBRARY=1) based on MOZ_ENABLE_LIBXUL. However we've not actually finished setting MOZ_ENABLE_LIBXUL yet until later on in the file, and hence JS_SHARED_LIBRARY doesn't get set for non-libxul builds.

I thought there was something wrong with it when I copied the stuff from Firefox, I just couldn't work it out at the time.

Anyway, patch attached to fix this.
Attachment #497559 - Flags: review?(bugspam.Callek)
Attachment #497559 - Flags: review?(bugspam.Callek) → review+
I committed this a few days ago:

http://hg.mozilla.org/comm-central/rev/977382635daa
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a2
You need to log in before you can comment on or make changes to this bug.