619189 - PHP variable error for 'downloadrefresh' when loading pages (once per http session)

Status: RESOLVED FIXED

(Camino Graveyard :: Product Site, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

NR mentioned this error when they were piddling around; I saw it today while poking error_log:

[Tue Dec 14 14:23:34 2010] [error] [client 86.0.136.227] PHP Notice:  Undefined variable: downloadrefresh in /www/cbo-www/inc/header_inc.php on line 17, referer: http://caminobrowser.org/download/

This only seems to be triggered once per http session, and obviously on pages where $downloadrefresh is not defined.

The header_inc line in question is:

17 <?php if ( $downloadrefresh == "1" ) {
18     echo "<meta http-equiv=\"refresh\" content=\"3;url=$downloadurl\">
19     
20     ";
21 } ?>

Have we switched PHP versions, and did syntax switch between them?

Comment 1

[Samuel Sidler (:ss)]

We definitely did switch PHP versions, but I can't answer the syntax question. I kind of wonder if this just needs an "else" statement that does nothing or if we have to define $downloadrefresh as "0" on every page that doesn't need an automatic refresh.

Comment 2

[Samuel Sidler (:ss)]

Ahh... This happens because we define $downloadrefresh *after* we parse an if statement for it. That's because we have to put the if statement in the header include (to place the meta tag in it) and the value in the main file because it varies by page. I'm not entirely sure how to fix this... I'll have to think about it.

(Note also that I'm testing things on www-stage for this and bug 619195.)

Comment 3

[Wevah (Nate Weaver)]

Change line 17 from

<?php if ( $downloadrefresh == "1" ) {

to

<?php if ( isset($downloadrefresh) && $downloadrefresh == "1" ) {

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Deployed; thanks!  I look forward to that log file getting smaller :D