619231 - Fennec UI should not enable Connect unless all fields are entered

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Ayan Shah[:ashah]]

Mozilla/5.0(Android; Linux armv7l; rv:2.0b8pre) Gecko/20101214 Firefox/4.0b8pre
Fennec/4.0b3pre

STR:
1. Open Fennec > Preferences
2. Make sure that you are not connectd to Sync.
3. Click on the "Connect" button.
4. Click on "I am not near my computer"
5. In the login screen that is shown, do not enter anything. Click "connect"

Expected Result:
Nothing should happen

Actual Result:
You are taken to the preferences page and the Sync shows "Not Connected. Unknown Error"

Comment 1

[Tony Chung [:tchung]]

This is another example of unhelpful error messages.   lets track all this and figure out how to redesign the workflow.

Comment 2

[Philipp von Weitershausen [:philikon]]

I'm not so sure this is a Sync bug. It seems more like a Fennec UI bug. The Firefox UI ensures that it doesn't call into Weave.Service with obviously bogus inputs (e.g. empty strings). In fact, it disables the buttons for such cases.

Comment 3

[Mike Connor [:mconnor]]

Yeah, concur, the UI should prevent this, rather than have us add strings for cases that UI shouldn't allow.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Adds code to enable / disable the "Connect" button. Checks when opening the manual dialog and as you type in the account, password and synckey fields. All fields must have some text before the "Connect" button is enabled.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 507472 [details] [diff] [review]
patch

>diff --git a/chrome/content/sync.js b/chrome/content/sync.js

>+    if (account && password && synckey)
>+      document.getElementById("syncsetup-button-connect").disabled = false;
>+    else
>+      document.getElementById("syncsetup-button-connect").disabled = true;
>+  },

Nit:
let disabled = !(account && password && synckey);
document.getElementById("syncsetup-button-connect").disabled = disabled;

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with nit fixed:
http://hg.mozilla.org/mobile-browser/rev/ba751c096419

Comment 8

[Ioana Chiorean]

verified fixed on build id: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre)
Gecko/20110304 Firefox/4.0b13pre Fennec /4.0b6pre