Ability to filter results to only show unstarred oranges/red

RESOLVED FIXED

Status

Tree Management Graveyard
TBPL
RESOLVED FIXED
7 years ago
3 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Dependency tree / graph

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
It would be nice to have a way to only show unstarred oranges so it will be easier to track them. The main use case would be on try server but unfortunately, it might be needed for mozilla-central when people are too lazy to star.
(Assignee)

Comment 1

7 years ago
Created attachment 497743 [details] [diff] [review]
Patch v1

This could probably be better but it's working.
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #497743 - Flags: review?(arpad.borsos)
(Assignee)

Updated

7 years ago
Blocks: 576544
Comment on attachment 497743 [details] [diff] [review]
Patch v1

Looks good, also thanks for adding it to the “provide UI” bug right away.

One nice followup would be to create an options objects instead of passing all the options as separate parameters.
Attachment #497743 - Flags: review?(arpad.borsos) → review+
Another thing that just occurred to me:
Please make sure to unlinkPush() the build when a note is added in the
if (result.runID in self._finishedResults) {
branch to make sure that future stars remove the build from the ui.
Sorry Mounir, I've probably broken your patch completely in the meantime...
Created attachment 499060 [details] [diff] [review]
v2

I've updated the patch to apply on trunk and I've moved the filtering into UserInterface.
Attachment #499060 - Flags: review?(arpad.borsos)
(Assignee)

Comment 6

7 years ago
(In reply to comment #5)
> Created attachment 499060 [details] [diff] [review]
> v2
> 
> I've updated the patch to apply on trunk and I've moved the filtering into
> UserInterface.

Thanks Markus :)
Comment on attachment 499060 [details] [diff] [review]
v2

>+  _isFailureState: function UserInterface__isFailureState(state) {
>+    switch (state) {
>+      case 'busted':
>+      case 'exception':
>+      case 'unknown':
>+      case 'testfailed':
>+        return true;
>+    }
>+    return false;
>+  },
>+
>+  _isUnstarredFailure: function UserInterface__isUnstarredFailure(result) {
>+    return !result.note && this._isFailureState(result.state);
>+  },
>+

An indexOf() would be more concise I believe, but fine anyway.
Attachment #499060 - Flags: review?(arpad.borsos) → review+
(In reply to comment #7)
> An indexOf() would be more concise

but not as diff-friendly ;)

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/df85211cba43
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
...plus Array.prototype.indexOf is new in ES5, so not present in slightly older browsers.  (Although I'm not sure how many active developers would be using such browsers -- IE<9 and maybe Opera users would be the only ones affected, I think, as WebKit's had it for years.)
'twas actually http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/8767e3de3ff9, for anyone looking for what they need to stick in the URL (&onlyunstarred=1)
(In reply to comment #9)
> ...plus Array.prototype.indexOf is new in ES5, so not present in slightly older
> browsers.  (Although I'm not sure how many active developers would be using
> such browsers -- IE<9 and maybe Opera users would be the only ones affected, I
> think, as WebKit's had it for years.)

We use it in some places already since quite a time and noone has complained yet :D
(Assignee)

Updated

7 years ago
Blocks: 626427
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.