cff.cc failing to build on Solaris with native Sun compiler

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: The Written Word, Unassigned)

Tracking

1.9.2 Branch
Other
Other
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101212 Remi/fc12 Firefox/3.6.13
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101212 Remi/fc12 Firefox/3.6.13

mozilla/gfx/ots/src/cff.cc fails to build on Solaris 8, 9, and 10 with the native Sun C++ compiler:
"cff.cc", line 190: Error: Formal argument x of type const std::pair<unsigned,::DICT_OPERAND_TYPE>& in call to std::vector<std::pair<unsigned,::DICT_OPERAND_TYPE> >::push_back(const std::pair<unsigned,::DICT_OPERAND_TYPE>&) is being passed std::pair<int,::DICT_OPERAND_TYPE>.
"cff.cc", line 196: Error: Formal argument x of type const std::pair<unsigned,::DICT_OPERAND_TYPE>& in call to std::vector<std::pair<unsigned,::DICT_OPERAND_TYPE> >::push_back(const std::pair<unsigned,::DICT_OPERAND_TYPE>&) is being passed std::pair<int,::DICT_OPERAND_TYPE>.
"cff.cc", line 265: Error: Formal argument x of type const std::pair<unsigned,::DICT_OPERAND_TYPE>& in call to std::vector<std::pair<unsigned,::DICT_OPERAND_TYPE> >::push_back(const std::pair<unsigned,::DICT_OPERAND_TYPE>&) is being passed std::pair<int,::DICT_OPERAND_TYPE>.
"cff.cc", line 276: Error: Formal argument x of type const std::pair<unsigned,::DICT_OPERAND_TYPE>& in call to std::vector<std::pair<unsigned,::DICT_OPERAND_TYPE> >::push_back(const std::pair<unsigned,::DICT_OPERAND_TYPE>&) is being passed std::pair<int,::DICT_OPERAND_TYPE>.
"cff.cc", line 318: Error: Formal argument x of type const std::pair<unsigned,::DICT_OPERAND_TYPE>& in call to std::vector<std::pair<unsigned,::DICT_OPERAND_TYPE> >::push_back(const std::pair<unsigned,::DICT_OPERAND_TYPE>&) is being passed std::pair<unsigned char,::DICT_OPERAND_TYPE>.

Reproducible: Always

Updated

7 years ago
Component: Build Config → Graphics
Product: SeaMonkey → Core
QA Contact: build-config → thebes
Version: unspecified → 1.9.2 Branch

Updated

7 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 1

7 years ago
Created attachment 498028 [details] [diff] [review]
workaround

I use this workaround to make it compile.
Created attachment 498031 [details] [diff] [review]
patch, add typecasts to fix the build failure

Seems like this should be easy to fix with a sprinkling of typecasts (but I don't have a Solaris box to try it).
Oops, sorry, didn't see that you'd already posted a patch!

It would be good to report this upstream (http://code.google.com/p/ots/).

Updated

7 years ago
Attachment #498028 - Attachment is patch: true
Attachment #498028 - Attachment mime type: application/octet-stream → text/plain

Comment 4

7 years ago
Created attachment 498038 [details] [diff] [review]
workaround revised

Revise the workaround with more accurate type name.

Reported at http://code.google.com/p/chromium/issues/detail?id=67121
Attachment #498028 - Attachment is obsolete: true
(Reporter)

Comment 5

7 years ago
(In reply to comment #4)
> Created attachment 498038 [details] [diff] [review]
> workaround revised
> 
> Revise the workaround with more accurate type name.
> 
> Reported at http://code.google.com/p/chromium/issues/detail?id=67121

This patch works for me.
Are these patches still good? If so I'll find a reviewer for them.

Comment 7

6 years ago
The patch is integrated in latest mozilla-central.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.