619324 - cff.cc failing to build on Solaris with native Sun compiler

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[The Written Word]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101212 Remi/fc12 Firefox/3.6.13
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101212 Remi/fc12 Firefox/3.6.13

mozilla/gfx/ots/src/cff.cc fails to build on Solaris 8, 9, and 10 with the native Sun C++ compiler:
"cff.cc", line 190: Error: Formal argument x of type const std::pair<unsigned,::DICT_OPERAND_TYPE>& in call to std::vector<std::pair<unsigned,::DICT_OPERAND_TYPE> >::push_back(const std::pair<unsigned,::DICT_OPERAND_TYPE>&) is being passed std::pair<int,::DICT_OPERAND_TYPE>.
"cff.cc", line 196: Error: Formal argument x of type const std::pair<unsigned,::DICT_OPERAND_TYPE>& in call to std::vector<std::pair<unsigned,::DICT_OPERAND_TYPE> >::push_back(const std::pair<unsigned,::DICT_OPERAND_TYPE>&) is being passed std::pair<int,::DICT_OPERAND_TYPE>.
"cff.cc", line 265: Error: Formal argument x of type const std::pair<unsigned,::DICT_OPERAND_TYPE>& in call to std::vector<std::pair<unsigned,::DICT_OPERAND_TYPE> >::push_back(const std::pair<unsigned,::DICT_OPERAND_TYPE>&) is being passed std::pair<int,::DICT_OPERAND_TYPE>.
"cff.cc", line 276: Error: Formal argument x of type const std::pair<unsigned,::DICT_OPERAND_TYPE>& in call to std::vector<std::pair<unsigned,::DICT_OPERAND_TYPE> >::push_back(const std::pair<unsigned,::DICT_OPERAND_TYPE>&) is being passed std::pair<int,::DICT_OPERAND_TYPE>.
"cff.cc", line 318: Error: Formal argument x of type const std::pair<unsigned,::DICT_OPERAND_TYPE>& in call to std::vector<std::pair<unsigned,::DICT_OPERAND_TYPE> >::push_back(const std::pair<unsigned,::DICT_OPERAND_TYPE>&) is being passed std::pair<unsigned char,::DICT_OPERAND_TYPE>.

Reproducible: Always

Comment 1

[Ginn Chen]

Attachment: workaround

I use this workaround to make it compile.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: patch, add typecasts to fix the build failure

Seems like this should be easy to fix with a sprinkling of typecasts (but I don't have a Solaris box to try it).

Comment 3

[Jonathan Kew [:jfkthame]]

Oops, sorry, didn't see that you'd already posted a patch!

It would be good to report this upstream (http://code.google.com/p/ots/).

Comment 4

[Ginn Chen]

Attachment: workaround revised

Revise the workaround with more accurate type name.

Reported at http://code.google.com/p/chromium/issues/detail?id=67121

Comment 5

[The Written Word]

(In reply to comment #4)
> Created attachment 498038 [details] [diff] [review]
> workaround revised
> 
> Revise the workaround with more accurate type name.
> 
> Reported at http://code.google.com/p/chromium/issues/detail?id=67121

This patch works for me.

Comment 6

[Benoit Girard (:BenWa)]

Are these patches still good? If so I'll find a reviewer for them.

Comment 7

[Ginn Chen]

The patch is integrated in latest mozilla-central.