Open Bug 619398 Opened 9 years ago Updated Last year
Overlay functions to a module
utilityOverlay used to be a place for functions that would be useful in all browser/* windows. 90 percent of it still fits this definition, and we should, therefore, move those 90 percent to a JS module. Originally, I wrote this fix for fixing bug 562998, however I'm afraid it's too big for landing in time for Firefox 4. While there's not too much room for potential regressions, and while it cannot break the current API as far as I can tell, it's just too bug.
Attachment #497820 - Flags: review?(gavin.sharp)
Comment on attachment 497820 [details] [diff] [review] patch Dietrich says I'm lying, and he'll also review this.
Attachment #497820 - Flags: review?(gavin.sharp) → review?(dietrich)
Blocks a blocker.
blocking2.0: --- → ?
I filed bug 619418 for contentAreaUtils.
The risk here is probably not worth the reward, and gavin says we can accomplish bug 562998 without this.
Dietrich: I know this doesn't block 2.0 anymore, but it'll be awesome if you could get this review done not after we branch. Otherwise the patch may become very outdated faster than you think it could.
9 years ago
Comment on attachment 497820 [details] [diff] [review] patch Pinged Mano about this. Needs re-evaluation as to whether it's necessary or not per Benjamin's comment.
Attachment #497820 - Flags: review?(dietrich)
You need to log in before you can comment on or make changes to this bug.