Open Bug 619398 Opened 9 years ago Updated Last year

Move utilityOverlay functions to a module

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

Tracking Status
blocking2.0 --- -
status2.0 --- wontfix

People

(Reporter: mano, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
utilityOverlay used to be a place for functions that would be useful in all browser/* windows. 90 percent of it still fits this definition, and we should, therefore, move those 90 percent to a JS module.

Originally, I wrote this fix for fixing bug 562998, however I'm afraid it's too big for landing in time for Firefox 4.  While there's not too much room for potential regressions, and while it cannot break the current API as far as I can tell, it's just too bug.
Attachment #497820 - Flags: review?(gavin.sharp)
Comment on attachment 497820 [details] [diff] [review]
patch

Dietrich says I'm lying, and he'll also review this.
Attachment #497820 - Flags: review?(gavin.sharp) → review?(dietrich)
Blocks a blocker.
Blocks: 562998
blocking2.0: --- → ?
The risk here is probably not worth the reward, and gavin says we can accomplish bug 562998 without this.
blocking2.0: ? → -
status2.0: --- → wontfix
Dietrich: I know this doesn't block 2.0 anymore, but it'll be awesome if you could get this review done not after we branch. Otherwise the patch may become very outdated faster than you think it could.
Comment on attachment 497820 [details] [diff] [review]
patch

Pinged Mano about this. Needs re-evaluation as to whether it's necessary or not per Benjamin's comment.
Attachment #497820 - Flags: review?(dietrich)
Assignee: asaf → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.