619441 - Have tests to make sure that we handle IDN domains correctly when manipulating DOM storage

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[(no longer active)]

The current removeDataFromDomain feature might be calling APIs which are not IDN-safe.  We need to test to ensure that IDN doesn't break removeDataFromDomain in any way.

Comment 1

[Honza Bambas (:mayhemer)]

I took the liberty of renaming this to a more general bug.  We actually don't have tests covering all API that is affected with using international domain names.  During review of Ehsan's patch I discovered some places that might not be correct.

I don't think we can fix the issues in Fx4 scope.  As I plan a big re-work of the DOM storage code for Fx next, we can do necessary fixes as part of that work.

Comment 2

[(no longer active)]

(In reply to comment #1)
> I took the liberty of renaming this to a more general bug.s as part of that
> work.

Well, I filed it for a different issue, which is making sure that the private browsing's forget about this site is IDN safe.  Now that you've morphed it, would you mind filing another bug for what I originally filed?  ;)

Comment 3

[Honza Bambas (:mayhemer)]

Ehsan, maybe, if you want to work on this, create tests for all places that use RemoveOwner and RemoveOwners API (also for PB and Session-only Cookies mode) that could be suspect to bad IDN handling.  If you find problems, just make the failing tests TODO.

Comment 4

[(no longer active)]

(In reply to comment #3)
> Ehsan, maybe, if you want to work on this, create tests for all places that use
> RemoveOwner and RemoveOwners API (also for PB and Session-only Cookies mode)
> that could be suspect to bad IDN handling.  If you find problems, just make the
> failing tests TODO.

I actually care about all of the data which is cleared based on the domain from nsIPrivateBrowsingService::RemoveDataFromDomain...

Comment 5

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.