61947 - Progress meter time left wrong

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[--disabled--Steve A Fink]

I just did a 9MB FTP download, and its estimate of the time remaining was pretty
poor -- it said 25 seconds were left just before it finished.

Comment 1

[Bradley Baetz]

Confirming. I noticed this yesterday - it doesn't appear to take into account
the time taken to select the download location, when mozilla is still
downloading anyway.  I waited 10 seconds from the time the dialog came up to
presing OK, and at the end of the download I was told that I had 8 seconds
remaining. I tried anoth file, waited 30 seconds before pressing OK, and at the
end I was told that I had 35 seconds to go. Since it was only counting down in
lots of 5 seconds, those are quite accurate except for the offset.

downloadProgress.js probably shouldn't be setting the start time to the current
time in onProgress. The %age bar was accurate, but the elapsed time was
incorrect (it started from 00:00, and it shouldn't have, because the downloading
started immediately.

That was on an HTTP download - changing componant.

Comment 2

[John Morrison]

-> XPApps: GUI Features - "Problems with the dialogs associated with 
downloading/saving files."

Comment 3

[sairuh (rarely reading bugmail)]

bill or mscott, does this belong to you? sounds like a recent regression.

Comment 4

[Scott MacGregor]

this belongs to me. 

Comment 5

[Scott MacGregor]

I fixed this along with something else. Adding appropriate triage keywords.

Comment 6

[Scott MacGregor]

Attachment: proposed fix. (Includes the fix for 66323

Comment 7

[Scott MacGregor]

this is now fixed. when you first see the progress dialog the Elasped time field
now counts the time we were downloading while the Open/Save dialog was open.

Comment 8

[Keyser Sose]

*** Bug 69037 has been marked as a duplicate of this bug. ***

Comment 9

[sairuh (rarely reading bugmail)]

vrfy fixed --ie, the Elapsed Time does take into account the time while the
Downloading and Save file picker dialogs were displayed [ie, includes initial
background downloading time]:

linux comm 2001.05.02.08
mac comm 2001.05.02.09
winnt moz 2001.05.02.12

Comment 10

[Ben Ruppel]

Okay, I'm seeing this again.  Actually, the numbers are strange, more like bug
69307 with figures like "0-13:0-11" (but that was marked as a dupe of this).  

It doesn't help that the file size has been reported as smaller than it really
is.  I'm downloading a 110 meg file, but mozilla thinks it's only 41 megs. 
Don't know if that's a cause or a symptom.

Comment 11

[Ben Ruppel]

Attachment: image from october 16, win32, trunk