619659 - nsPlacesAutoComplete.js depends on nsIPrivateBrowsingService being implemented | TEST-UNEXPECTED-FAIL | test_tabmatches.js | test failed (with xpcshell return code: 3) (Perma Orange for Non-FF apps)

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

nsIPrivateBrowsingService is only implemented for Firefox, and bug 582703 didn't account for that.

Therefore non-Firefox apps have a permanent orange during xpcshell tests (and, of course, wouldn't be able to use the auto-complete properly).

Patch attached that fixes this. Asking for two reviewers, I'll take whichever one I get first ;-)

Comment 1

[Marco Bonardo [:mak]]

Comment on attachment 498089 [details] [diff] [review]
The fix

ah, sorry, the fact pb is in browser but toolkit components depend on it is still confusing.

Comment 2

[Mark Banner (:standard8)]

I had thought about making Thunderbird define the pb service, but I'm not quite sure if that's a sensible thing yet.


I checked this in with a=unit test bustage fix for non-FF apps. I thought that was reasonable wrt the current tree rules:

http://hg.mozilla.org/mozilla-central/rev/d386e59d2c72