nsPlacesAutoComplete.js depends on nsIPrivateBrowsingService being implemented | TEST-UNEXPECTED-FAIL | test_tabmatches.js | test failed (with xpcshell return code: 3) (Perma Orange for Non-FF apps)

RESOLVED FIXED in mozilla2.0b9

Status

()

RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({intermittent-failure})

Trunk
mozilla2.0b9
intermittent-failure
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 498089 [details] [diff] [review]
The fix

nsIPrivateBrowsingService is only implemented for Firefox, and bug 582703 didn't account for that.

Therefore non-Firefox apps have a permanent orange during xpcshell tests (and, of course, wouldn't be able to use the auto-complete properly).

Patch attached that fixes this. Asking for two reviewers, I'll take whichever one I get first ;-)
Attachment #498089 - Flags: review?(sdwilsh)
Attachment #498089 - Flags: review?(mak77)
Comment on attachment 498089 [details] [diff] [review]
The fix

ah, sorry, the fact pb is in browser but toolkit components depend on it is still confusing.
Attachment #498089 - Flags: review?(sdwilsh)
Attachment #498089 - Flags: review?(mak77)
Attachment #498089 - Flags: review+
I had thought about making Thunderbird define the pb service, but I'm not quite sure if that's a sensible thing yet.


I checked this in with a=unit test bustage fix for non-FF apps. I thought that was reasonable wrt the current tree rules:

http://hg.mozilla.org/mozilla-central/rev/d386e59d2c72
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9

Updated

8 years ago
Blocks: 438871
Keywords: intermittent-failure
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.