Closed Bug 619659 Opened 10 years ago Closed 10 years ago
Places Auto Complete .js depends on ns IPrivate Browsing Service being implemented | TEST-UNEXPECTED-FAIL | test _tabmatches .js | test failed (with xpcshell return code: 3) (Perma Orange for Non-FF apps)
nsIPrivateBrowsingService is only implemented for Firefox, and bug 582703 didn't account for that. Therefore non-Firefox apps have a permanent orange during xpcshell tests (and, of course, wouldn't be able to use the auto-complete properly). Patch attached that fixes this. Asking for two reviewers, I'll take whichever one I get first ;-)
Comment on attachment 498089 [details] [diff] [review] The fix ah, sorry, the fact pb is in browser but toolkit components depend on it is still confusing.
I had thought about making Thunderbird define the pb service, but I'm not quite sure if that's a sensible thing yet. I checked this in with a=unit test bustage fix for non-FF apps. I thought that was reasonable wrt the current tree rules: http://hg.mozilla.org/mozilla-central/rev/d386e59d2c72
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in before you can comment on or make changes to this bug.