619682 - Addons Manager "Available Updates" pane shown even if no updates, if check for updates performed from "Recent Updates" section

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Stappel]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b9pre) Gecko/20101216 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b9pre) Gecko/20101216 Firefox/4.0b9pre

Sometimes it shows the "available updates" tab on add-on manager page, when there is no update available.


Reproducible: Always

Steps to Reproduce:
in the add-ons manager page
1. click on the "recent updates" on the left bar
2. then press the "wheely button" en click "check for updates"
3. now a new item appears on the left: "available updates"
4. click it and see: no updates found

this does not appear when you click on "check for updates" when you do not goto the recent updates page first.
Actual Results:  
the tab

Expected Results:  
no extra tab

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

If i recall correctly this can be triggered by some Extensions, no?

Comment 2

[Ed Morley [:emorley]]

Until recently, certain addons (eg Scriptish) triggered an underlying bug that meant the "available updates" section showed even if no updates. This was fixed in bug 591024.

Have you definitely seen the issue since bug 591024 landed? (~12th Dec)
	
If so, can you try with a new profile (ie: so empty of addons) and see if it still occurs:
http://support.mozilla.com/en-US/kb/Basic%20Troubleshooting#w_make-a-new-profile

Comment 3

[Ed Morley [:emorley]]

Have you been able to try with a clean profile, per comment 2?

Thanks!

Comment 4

[Stappel]

Yes, also in a clean profile, even a clean install.
steps:
- install windows xp
- install firefox 4.0 beta 8
- start firefox 4.0 beta 8
- close firefox
- install firefox 4.0b9pre nightly 2010-12-30 (http://hg.mozilla.org/mozilla-central/rev/ec3e4786877d)
- start firefox 4.0b9pre
- goto add-ons manager
- on the top right click on the button and select: view recent updates
- on the left click in the new item: recent updates
- on the top right click on the button and select: check for updates
- on the left there will be a new item: available updates
- click on it and it shows: no updates found

Comment 5

[Stappel]

Attachment: no addons available

Comment 6

[Ed Morley [:emorley]]

Thanks for the clarification, have been able to follow the STR and can confirm with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20101230 Firefox/4.0b9pre ID:20101230030351

For reference, reduced STR:
1) Start Firefox/Minefield with clean profile.
2) Open addons manager.
3) Click the cog icon dropdown top right of the addons mangager, then "view recent updates" (no addons need to be installed).
4) Click the cog again and choose "check for updates".
5) Observe sections in left-hand sidebar of addons manager.

Expected:
- The "Available Updates" entry in the left hand sidebar only appears if updates are available.

Actual:
- Even with no addons installed/no updates downloaded in step #4, "Available Updates" appears in the left hand sidebar, which when clicked on shows "no updates found".
- This only occurs if the check for updates was performed whilst in the "recent updates" section.

Regression range...

Last good nightly: 2010-12-08 
First bad nightly: 2010-12-09

Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=95452499f3d6&tochange=11e328a49e0a

In that range is:
http://hg.mozilla.org/mozilla-central/rev/c44ffda23deb
Dave Townsend — Bug 591024: Only show "Available Updates" pane when pending updates are available.

...so blocking bug 591024.

Thanks for the report! :-)

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

updateAvailableCount() didn't take into account that gUpdatesView is really two views handed by one object. Sadly, can't seem to test this without a bunch of setTimeout() calls - which would be horribly unreliable.

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/c22c9543a449

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10pre) Gecko/20110119 Firefox/4.0b10pre ID:20110119030331

Blair, do we have an automated test or is a manual test necessary?

Comment 10

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #9)
> Blair, do we have an automated test or is a manual test necessary?

Manual test for this one. Sadly, any automated test would be unreliable (see comment 7).