619764 - Fennec content process crash reporter UI does not respect MOZ_CRASHREPORTER_NO_REPORT

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[cmtalbert]

While testing talos we encountered a content process crash that caused the content process crash report UI to come up.  This was surprising because we'd set the MOZ_CRASHREPORTER_NO_REPORT and did not expect to see any UI come up.  

Remote Talos will have to start checking for the minidumps and will terminate the run on that case.  But anyway, the in process crash reporter UI should respect this flag.

Comment 1

[cmtalbert]

Actually, in addition we need a new env variable (or preference) to set.  If this new preference is set then fennec should exit when a content process crashes.  this will make it much easier for us to run talos deterministically.

So, two changes for fennec:
1. Respect the variable and not show the UI
2. Need a new preference (or env var) so that if the content process crashes, fennec exits.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch adds support for MOZ_CRASHREPORTER_NO_REPORT (we just skip showing the UI) and a new MOZ_CRASHREPORTER_SHUTDOWN (we forcibly quit the app). Tested ok when I manually killed the child process.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/136a9e61f8a2

If you hate MOZ_CRASHREPORTER_SHUTDOWN, tell me and I can change it to something better

Comment 4

[(not currently active) Ted Mielczarek]

Can you document that new variable here:
https://developer.mozilla.org/en/Environment_variables_affecting_crash_reporting
?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #4)
> Can you document that new variable here:
> https://developer.mozilla.org/en/Environment_variables_affecting_crash_reporting
> ?

Done

Comment 6

[Tony Chung [:tchung]]

Clint, can you verify this is fixed?   Thanks

Comment 7

[cmtalbert]

Yep, checked with Jmaher and this is working as expected in our automation.