Closed Bug 619764 Opened 9 years ago Closed 9 years ago

Fennec content process crash reporter UI does not respect MOZ_CRASHREPORTER_NO_REPORT

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: cmtalbert, Assigned: mfinkle)

References

Details

Attachments

(1 file)

While testing talos we encountered a content process crash that caused the content process crash report UI to come up.  This was surprising because we'd set the MOZ_CRASHREPORTER_NO_REPORT and did not expect to see any UI come up.  

Remote Talos will have to start checking for the minidumps and will terminate the run on that case.  But anyway, the in process crash reporter UI should respect this flag.
Flags: wanted-fennec1.0?
Actually, in addition we need a new env variable (or preference) to set.  If this new preference is set then fennec should exit when a content process crashes.  this will make it much easier for us to run talos deterministically.

So, two changes for fennec:
1. Respect the variable and not show the UI
2. Need a new preference (or env var) so that if the content process crashes, fennec exits.
Attached patch patchSplinter Review
This patch adds support for MOZ_CRASHREPORTER_NO_REPORT (we just skip showing the UI) and a new MOZ_CRASHREPORTER_SHUTDOWN (we forcibly quit the app). Tested ok when I manually killed the child process.
Assignee: nobody → mark.finkle
Attachment #498214 - Flags: review?(21)
pushed:
http://hg.mozilla.org/mobile-browser/rev/136a9e61f8a2

If you hate MOZ_CRASHREPORTER_SHUTDOWN, tell me and I can change it to something better
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
(In reply to comment #4)
> Can you document that new variable here:
> https://developer.mozilla.org/en/Environment_variables_affecting_crash_reporting
> ?

Done
Clint, can you verify this is fixed?   Thanks
Yep, checked with Jmaher and this is working as expected in our automation.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.