619786 - System titlebar seen at all times

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wikiwide]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12 ( .NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Maemo; Linux armv7l; rv:2.0b9pre) Gecko/20101216 Firefox/4.0b9pre Fennec/4.0b4pre

Qt version of Fennec nightly
While previous versions of Fennec (4.0b3pre one of them) replaced system titlebar with Fennec urlbar and buttons "Switch between application" and "Close Fennec window", this 4.0b4pre show system titlebar above urlbar and doesn't have its own buttons "Switch between application" and "Close Fennec window".

Reproducible: Always

Steps to Reproduce:
1. Open Fennec on Maemo.
2.
3.
Actual Results:  
System titlebar above urlbar.

Expected Results:  
System titlebar replaced with urlbar.

Fennec Qt on Maemo 5.

Comment 1

[Wikiwide]

Attachment: Screenshot

Comment 2

[Wikiwide]

If I start "fennec" from Terminal, it shows system titlebar. If I start "fennec
about:config" from Terminal, it doesn't show system titlebar, and the close
Fennec window button works correctly, but switch to other application button
doesn't do anything, so I have to use "Ctrl+Backspace" instead.

Comment 3

[Martijn Wargers (dead)]

Not sure who's working on Fennec QT builds, but this sounds like a bad bug.

Comment 4

[Martijn Wargers (dead)]

Actually I can reproduce this on:
Mozilla/5.0 (Maemo; Linux armv7l; rv:2.0b9pre) Gecko/20101220
Firefox/4.0b9pre Fennec/4.0b4pre

Perhaps this was an intentional change?

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

qt isn't blocking our release

Comment 6

[Martijn Wargers (dead)]

I'm using a gtk build.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

If this is happening on the GTK build, we should get it fixed.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Can we get a regression range?

Comment 9

[Martijn Wargers (dead)]

This regressed between 2010-12-15: http://hg.mozilla.org/mozilla-central/rev/90b17476216d
and 2010-12-16: http://hg.mozilla.org/mozilla-central/rev/a6f0fcaf31f9

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Found the offending patch:

http://hg.mozilla.org/mobile-browser/rev/1c8519353a3c

from bug 617851

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

defaultURL was undefined in BrowserCLH.js, and openWindow didn't like that. This patch adds the getHomepage() back to CLH and juggles the URL in browser.js

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/e4a6d55bde06

Comment 13

[Martijn Wargers (dead)]

Verified fixed. Thanks.