619827 - throw from AudioTrack constructor kills fennec

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1

If you load a file that has a sample that isn't support, we will throw:


W/System.err( 3061): java.lang.IllegalArgumentException: 1000Hz is not a supported sample rate.
W/System.err( 3061): 	at android.media.AudioTrack.audioParamCheck(AudioTrack.java:317)
W/System.err( 3061): 	at android.media.AudioTrack.<init>(AudioTrack.java:268)
W/System.err( 3061): 	at dalvik.system.NativeStart.run(Native Method)
W/System.err( 3061): 	at dalvik.system.NativeStart.run(Native Method)

If this isn't caught, fennec isn't usable as it freezes.

Comment 1

[Matthew Gregan [:kinetik]]

We probably also need to run the error-exit code in the OOM-check branch directly below it, otherwise we'll leak a local frame.

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 498243 [details] [diff] [review]
patch v.1

You still need to pop the local frame and delete that global reference.

Comment 3

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 498246 [details] [diff] [review]
patch v.1

Not bumping the version on versioned patches is confusing.

Comment 5

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/fc50c521bf48

Comment 6

[u279076]

Can someone help me verify this bug?  I don't have access to a Firefox Mobile capable device.