Closed
Bug 619839
Opened 14 years ago
Closed 13 years ago
Update m-c agent to bob20 version of the sutagent
Categories
(Testing :: General, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: cmtalbert, Unassigned)
Details
Attachments
(2 files)
53.81 KB,
patch
|
Details | Diff | Splinter Review | |
47.01 KB,
patch
|
Details | Diff | Splinter Review |
This attempt was backed out (see bug 614173), we need to get it back into m-c. This is a vehicle for that.
Comment 1•14 years ago
|
||
This will remove the unused import that broke the build
Attachment #498268 -
Flags: review?(ctalbert)
One of the reasons that the code broke was not only did it contain an unused import statement but it also referenced code that did not live in m-c, namely the Android agent Watcher application. The watcher needs to live in m-c as well, and this patch will add the required code and makefile to put the watcher into m-c. This builds, but I'm not totally happy with it. Bob, I need you to take a look at it. I think this only works because I am depending on the generated IDL file existing in m-c -- I'm not creating that idl file from the aidl file in your source. I think I need to add a step for that to the makefile. Is that correct? Can you look over your Eclipse settings to get me the command line for that step? Let me know what else you think about this patch.
Attachment #499981 -
Flags: feedback?(bmoss)
Comment 3•14 years ago
|
||
You shouldn't need an idl file, I think we can drop the aidl file, it is a remnant of a previous design. So if it is building and working I think you are good to go.
Attachment #498268 -
Flags: review?(ctalbert)
Attachment #499981 -
Flags: feedback?(bmoss)
This is superseded by bug 650110 -->WONTFIX
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Updated•11 years ago
|
Component: Infrastructure → General
You need to log in
before you can comment on or make changes to this bug.
Description
•