The defaults of these two dialog checkboxes aren't persistent. I.e. if you change then, run a search, close the dialog... and then reopen it again, the original values will be present.
This isn't very handy if, like me, you have dozens of sub-mailboxes, but do most of your searches in your Inbox and server-side.
In that case, you'd want to change your preferences to disable "Search subfolders", and enable "Run search on server" (which should be the default on IMAP3 anyway).
Please add preferences for these.
I think persisting the values may be better than having specific preferences. I think a preference would be too much for the normal case, and just remembering what the user did before would be easier and simpler.
(In reply to comment #1)
> I think persisting the values may be better than having specific preferences. I
> think a preference would be too much for the normal case, and just remembering
> what the user did before would be easier and simpler.
Updating summary to match.
In our enterprise environment, "Run search on server" is the only way to perform message body searches because we don't use the 'new' Thunderbird searching/indexing, having found it unreliable.
To achieve an always-on "Run search on server": for each new version of Thunderbird, I am manually patching SearchDialog.xul so that "Run search on server" defaults to ON. A fix for this bug would mean that tedious step is no longer required.
Created attachment 602976 [details] [diff] [review]
A very basic approach would be to just add the persist attribute to both elements. The online/offline code toggles the pref though ;/
This patch persists the checked attributes and hides the online option (not just disabling like now) when you're offline.
A third potential option would be to add a per server default pref...
Comment on attachment 602976 [details] [diff] [review]
>@@ -342,44 +342,42 @@ function selectFolder(folder)
> function updateSearchFolderPicker(folderURI)
>- SetFolderPicker(folderURI, gFolderPicker.id);
>+ SetFolderPicker(folderURI, gFolderPicker.id);
Ugh. I'm sure I asked for it, but these spacing changes make it tough to review… ;)
Having said that, it all looks good as far as I can tell. r=me!
http://hg.mozilla.org/comm-central/rev/99fcdce4abb4 -> FIXED