Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Persist the checkbox values for the advanced search dialog ("Search subfolders" and "Run search on server")

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Search
--
minor
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: Philip Prindeville, Assigned: Magnus Melin)

Tracking

Thunderbird 14.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
The defaults of these two dialog checkboxes aren't persistent.  I.e. if you change then, run a search, close the dialog... and then reopen it again, the original values will be present.

This isn't very handy if, like me, you have dozens of sub-mailboxes, but do most of your searches in your Inbox and server-side.

In that case, you'd want to change your preferences to disable "Search subfolders", and enable "Run search on server" (which should be the default on IMAP3 anyway).

Please add preferences for these.
I think persisting the values may be better than having specific preferences. I think a preference would be too much for the normal case, and just remembering what the user did before would be easier and simpler.
Keywords: helpwanted
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [good first bug]
(In reply to comment #1)
> I think persisting the values may be better than having specific preferences. I
> think a preference would be too much for the normal case, and just remembering
> what the user did before would be easier and simpler.

Agreed
Updating summary to match.
Summary: No preferences for search dialog checkboxes "Search subfolders" and "Run search on server" → Persist the checkbox values for the advanced search dialog ("Search subfolders" and "Run search on server")

Comment 4

6 years ago
In our enterprise environment, "Run search on server" is the only way to perform message body searches because we don't use the 'new' Thunderbird searching/indexing, having found it unreliable.

To achieve an always-on "Run search on server": for each new version of Thunderbird, I am manually patching SearchDialog.xul so that "Run search on server" defaults to ON.  A fix for this bug would mean that tedious step is no longer required.
(Assignee)

Comment 5

5 years ago
Created attachment 602976 [details] [diff] [review]
proposed fix

A very basic approach would be to just add the persist attribute to both elements. The online/offline code toggles the pref though ;/

This patch persists the checked attributes and hides the online option (not just disabling like now) when you're offline.

A third potential option would be to add a per server default pref...
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #602976 - Flags: review?(bwinton)
(Assignee)

Updated

5 years ago
Keywords: helpwanted
Whiteboard: [good first bug]
Comment on attachment 602976 [details] [diff] [review]
proposed fix

>+++ b/mail/base/content/SearchDialog.js
>@@ -342,44 +342,42 @@ function selectFolder(folder)
> function updateSearchFolderPicker(folderURI)
> {
>-    SetFolderPicker(folderURI, gFolderPicker.id);
>+  SetFolderPicker(folderURI, gFolderPicker.id);

Ugh.  I'm sure I asked for it, but these spacing changes make it tough to review…  ;)

Having said that, it all looks good as far as I can tell.  r=me!

Thanks,
Blake.
Attachment #602976 - Flags: review?(bwinton) → review+
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/comm-central/rev/99fcdce4abb4 -> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.