JM: shrink JITScript on 64-bit platforms

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

(Whiteboard: [cib-memory], fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 498271 [details] [diff] [review]
patch (against TM 58597:dab87d48d3dd)

JITScript is sub-optimally packed on 64-bit platforms.  The attached patch reduces its size from 232 to 200 bytes.  On a 20-tab cad-comics browser run, this saves 357,102 bytes.  It's a small win, but it's a dead-simple patch.
Attachment #498271 - Flags: review?(dvander)
(Assignee)

Updated

7 years ago
blocking2.0: --- → ?
(Assignee)

Updated

7 years ago
Whiteboard: [cib-memory]
Attachment #498271 - Flags: review?(dvander) → review+
(Assignee)

Comment 1

7 years ago
A |bool singleStepMode| field was added since I created the patch, I squeezed that into the bottom bit of |nCallSites|.

http://hg.mozilla.org/tracemonkey/rev/35697ebafa6c
Whiteboard: [cib-memory] → [cib-memory], fixed-in-tracemonkey
blocking2.0: ? → beta9+
http://hg.mozilla.org/mozilla-central/rev/35697ebafa6c
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 3

7 years ago
As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)
No longer blocks: 615199
blocking2.0: beta9+ → betaN+
Blocks: 615199

Comment 4

7 years ago
Fixing fields my automated script accidentally blanked. Apologies for the bugspam
You need to log in before you can comment on or make changes to this bug.