Closed Bug 619920 Opened 14 years ago Closed 13 years ago

TEST-UNEXPECTED-FAIL | test_download_embed_bookmarks.js | head_autocomplete.js | Didn't find the current result ('http://download/', 'download2') in expected:

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b12

People

(Reporter: standard8, Assigned: mak)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

patch v1.0
1.08 KB, patch
sdwilsh
: review+
Details | Diff | Splinter Review 
Random orange on Linux VMs seen on Thunderbird tree since the latest places merge:

TEST-INFO | (xpcshell/head.js) | test 2 pending
3: Searching for download uri does not match
Searching for.. 'download2'
TEST-INFO | (xpcshell/head.js) | test 2 finished
TEST-PASS | /buildbot/comm-central-trunk-linux-opt-unittest-xpcshell/build/xpcshell/tests/toolkit/components/places/tests/autocomplete/head_autocomplete.js | [null : 115] 1 == 1
TEST-PASS | /buildbot/comm-central-trunk-linux-opt-unittest-xpcshell/build/xpcshell/tests/toolkit/components/places/tests/autocomplete/head_autocomplete.js | [null : 119] 1 == 1
Looking for 'http://download/', 'download2' in expected results...
TEST-UNEXPECTED-FAIL | /buildbot/comm-central-trunk-linux-opt-unittest-xpcshell/build/xpcshell/tests/toolkit/components/places/tests/autocomplete/head_autocomplete.js | Didn't find the current result ('http://download/', 'download2') in expected:  - See following stack:
JS frame :: /buildbot/comm-central-trunk-linux-opt-unittest-xpcshell/build/xpcshell/head.js :: do_throw :: line 439
JS frame :: /buildbot/comm-central-trunk-linux-opt-unittest-xpcshell/build/xpcshell/tests/toolkit/components/places/tests/autocomplete/head_autocomplete.js :: <TOP_LEVEL> :: line 154
JS frame :: jar:file:///buildbot/comm-central-trunk-linux-opt-unittest-xpcshell/build/thunderbird/omni.jar!/components/nsPlacesAutoComplete.js :: PAC_notifyResults :: line 773
JS frame :: jar:file:///buildbot/comm-central-trunk-linux-opt-unittest-xpcshell/build/thunderbird/omni.jar!/components/nsPlacesAutoComplete.js :: PAC_finishSearch :: line 719
JS frame :: jar:file:///buildbot/comm-central-trunk-linux-opt-unittest-xpcshell/build/thunderbird/omni.jar!/components/nsPlacesAutoComplete.js :: PAC_handleCompletion :: line 620
JS frame :: jar:file:///buildbot/comm-central-trunk-linux-opt-unittest-xpcshell/build/thunderbird/omni.jar!/components/nsPlacesAutoComplete.js :: ACSCW_handleCompletion :: line 208
TEST-INFO | (xpcshell/head.js) | exiting test

http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1292595413.1292596932.17182.gz#err0
Whiteboard: [orange]
Blocks: 438871
Attached patch patch v1.0 — — Splinter Review 
The short story: we don't correctly wait for frecency.

The long story is that this usually still passes because there are 2 methods updating frecency, the first one is after adding a visit, the second one is delayed places-init-complete after a new database is created. So in most cases we hit one of these 2 and the test passes, sometimes they run after and the test fails.

This could also fix bug 621098 but I've been unable to proof that locally (while I've been able to check this bug locally).
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #514402 - Flags: review?(sdwilsh)
Comment on attachment 514402 [details] [diff] [review]
patch v1.0

r=sdwilsh
Attachment #514402 - Flags: review?(sdwilsh) → review+
I'm confident that this is solved

http://hg.mozilla.org/mozilla-central/rev/f8e466a3765d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: