61996 - "Save" not available in "HTML Source" View

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Sean Chitwood]

Steps to reproduce:
1) Open an Exisiting Document 
2) Change to view HTML Source
3) Add "<!-- This is a test comment -->" to the document.


Expected behavior:
The Save button should become active

Actual behavior:
Save buttin remains in active

Build: Gecko/20001028

Comment 1

[Fabian Guisset]

Confirmed build 2000120420 win32. Switching back to "Normal Edit Mode", the save
button is enabled.
Did not find any duplicate, could this be a regression?
Fabian.

Comment 2

[rubydoo123]

that is correct, we force menu operations from the wysiwyg mode, assigning to
cmanske and setting to future

Comment 3

[Charles Manske]

Current HTML source editing is a short-term kludge: it is simply a textarea and
the normal command enabling/disabling doesn't work while editing source.
These problems will go away after embedding/modularity work when we can use the
full text editor (with its own commands includind enabling behavior) for HTML
source. I'm not sure that will be done by milestone 0.9, but if not, then soon
after.

Comment 4

[sairuh (rarely reading bugmail)]

i see this on linux, so marking all/all. [2001.01.11.08, mozilla verif] this
would not only convenient and useful to have implemented, but also important for
many folx who wish to hack html directly. :)

Comment 5

[Charles Manske]

We actually DO support "Save" while in HTML Source mode. It automatically
switches back to 'Normal' mode and saves the file. The problem is that "Save"
is disabled if user has not made any changes in Normal mode or has just saved
the file. So to continue with the current source-editing kludge, the
simplest short-term solution is to set the modification flag before editing the
source so the Save button is enabled.

Comment 6

[Simon Fraser [no longer active]]

I think that's the wrong solution; it causes the modified flag to get out of step 
with the contents of the document (DOM, not source).

I think the best approach is to change the IsCommandEnabled for the save command 
to 'know about' source mode.

Comment 7

[Charles Manske]

You're correct - fix will be attached.

Comment 8

[Charles Manske]

Attachment: bug fix

Comment 9

[Charles Manske]

attached fix was checked in.

Comment 10

[Charles Manske]

checked in last week.

Comment 11

[sujay]

okay this is working however we two more problems now...
filing separate bugs.

verified in 1/23 build.