Closed Bug 619967 Opened 9 years ago Closed 8 years ago

non-directional filter primitive attributes with percentage values are not resolved correctly

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: heycam, Assigned: longsonr)

References

()

Details

Attachments

(3 files, 1 obsolete file)

http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectMiniApproved/filters-displace-02-f.html currently fails due to some strange colors near the edge of the displaced image.
I can't see it. Can you describe in more detail. Maybe with a screenshot with the differences circled?
Attached image Screenshot
This might be a Mac only issue -- I haven't tried others yet.
Attached patch patch?Splinter Review
Does this fix it? It seems the right thing to do according to http://www.w3.org/TR/SVG/coords.html#Units_viewport_percentage.

I don't know how to write a test for this.
Attachment #559695 - Flags: review?(roc)
Attachment #559695 - Flags: feedback?(cam)
It's a bit weird that 'scale' is described as a number in some places but is treated in the primitiveUnits coordinate system, so it's really a length. The spec could use some cleanup there.
Cameron, do you think you'll get a chance to check this patch out soon?
I will do so as soon as I return from my travels; ping me again if I don't respond before November 9.
It's November 10th now :-)
Sorry for the delay.  I took a look at the patch, and I think we want this fix, but it doesn't fix the problem for this particular bug (the strange aqua colours at the left edge of the gradient in the top subtest).  I'll attach a test for the scale="" coordinate space conversion problem that this patch fixes.

BTW, does this also affect some lighting filter primitives?  It looks like they might also have been using this function.
Attached image test for attachment 559695 patch (obsolete) —
Comment on attachment 559695 [details] [diff] [review]
patch?

We want this patch, but it doesn't fix this bug.
Attachment #559695 - Flags: feedback?(cam) → feedback+
Probably best to clone this bug and make the clone be about the original issue and then rename this one to what it fixes and land the patches. Can you do that Cameron please?
Blocks: 716347
Summary: feDisplacementMap test shows unexpected colors → non-directional filter primitive attributes with percentage values are not resolved correctly
Assignee: nobody → longsonr
Status: NEW → ASSIGNED
test as a patch
Attachment #574141 - Attachment is obsolete: true
Attachment #586787 - Flags: review?(longsonr)
Attachment #586787 - Flags: review?(longsonr) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/1848f311b786
https://hg.mozilla.org/integration/mozilla-inbound/rev/20ae82960dc3
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → mozilla12
Thanks Cameron and my apologies for muddying up this bug.
You need to log in before you can comment on or make changes to this bug.