The default bug view has changed. See this FAQ.

non-directional filter primitive attributes with percentage values are not resolved correctly

RESOLVED FIXED in mozilla12

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: heycam, Assigned: Robert Longson)

Tracking

(Blocks: 1 bug)

Trunk
mozilla12
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectMiniApproved/filters-displace-02-f.html currently fails due to some strange colors near the edge of the displaced image.
(Assignee)

Comment 1

6 years ago
I can't see it. Can you describe in more detail. Maybe with a screenshot with the differences circled?
(Reporter)

Comment 2

6 years ago
Created attachment 498401 [details]
Screenshot

This might be a Mac only issue -- I haven't tried others yet.
(Assignee)

Comment 3

6 years ago
Created attachment 559695 [details] [diff] [review]
patch?

Does this fix it? It seems the right thing to do according to http://www.w3.org/TR/SVG/coords.html#Units_viewport_percentage.

I don't know how to write a test for this.
Attachment #559695 - Flags: review?(roc)
Attachment #559695 - Flags: feedback?(cam)
Attachment #559695 - Flags: review?(roc) → review+
It's a bit weird that 'scale' is described as a number in some places but is treated in the primitiveUnits coordinate system, so it's really a length. The spec could use some cleanup there.
(Assignee)

Comment 5

6 years ago
Cameron, do you think you'll get a chance to check this patch out soon?
(Reporter)

Comment 6

6 years ago
I will do so as soon as I return from my travels; ping me again if I don't respond before November 9.
(Assignee)

Comment 7

5 years ago
It's November 10th now :-)
(Reporter)

Comment 8

5 years ago
Sorry for the delay.  I took a look at the patch, and I think we want this fix, but it doesn't fix the problem for this particular bug (the strange aqua colours at the left edge of the gradient in the top subtest).  I'll attach a test for the scale="" coordinate space conversion problem that this patch fixes.

BTW, does this also affect some lighting filter primitives?  It looks like they might also have been using this function.
(Reporter)

Comment 9

5 years ago
Created attachment 574141 [details]
test for attachment 559695 [details] [diff] [review] patch
(Reporter)

Comment 10

5 years ago
Comment on attachment 559695 [details] [diff] [review]
patch?

We want this patch, but it doesn't fix this bug.
Attachment #559695 - Flags: feedback?(cam) → feedback+
(Assignee)

Comment 11

5 years ago
Probably best to clone this bug and make the clone be about the original issue and then rename this one to what it fixes and land the patches. Can you do that Cameron please?
(Reporter)

Updated

5 years ago
Blocks: 716347
(Reporter)

Updated

5 years ago
Summary: feDisplacementMap test shows unexpected colors → non-directional filter primitive attributes with percentage values are not resolved correctly
(Reporter)

Updated

5 years ago
Assignee: nobody → longsonr
Status: NEW → ASSIGNED
(Reporter)

Comment 12

5 years ago
Created attachment 586787 [details] [diff] [review]
patch adding a test

test as a patch
Attachment #574141 - Attachment is obsolete: true
Attachment #586787 - Flags: review?(longsonr)
(Assignee)

Updated

5 years ago
Attachment #586787 - Flags: review?(longsonr) → review+
(Reporter)

Comment 13

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1848f311b786
https://hg.mozilla.org/integration/mozilla-inbound/rev/20ae82960dc3
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → mozilla12
(Assignee)

Comment 14

5 years ago
Thanks Cameron and my apologies for muddying up this bug.
https://hg.mozilla.org/mozilla-central/rev/20ae82960dc3
https://hg.mozilla.org/mozilla-central/rev/1848f311b786
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.