Closed Bug 620059 Opened 14 years ago Closed 14 years ago

Tab bar icons have wrong gradient when window loses focus.

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 4.0b9
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: caspy77, Assigned: mstange)

References

Details

(Keywords: regression)

Attachments

(2 files)

Tab bar icons lose theming when window loses focus.
24.15 KB, image/png
Details
add !importants
994 bytes, patch
dao
: review+
beltzner
: approval2.0+
Details | Diff | Splinter Review 
I have a dark persona installed (called Classic Black).
I noticed today that when the window lost focus the icons in the tab bar row seem to lose their dark theming.
I've attached a screenshot.

I'm running a nightly build on a Mac (Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9pre) Gecko/20101217 Firefox/4.0b9pre)
This is a regression from bug 598920 and it also happens without Personas.
-moz-any changed the specificity of the background:none override, and now the :-moz-window-inactive rule for regular toolbarbuttons has a higher specificity.
Blocks: 598920
blocking2.0: --- → ?
Keywords: regression
Hardware: x86 → All
Version: unspecified → Trunk
Summary: Tab bar icons lose Persona theming when window loses focus. → Tab bar icons have wrong gradient when window loses focus.
Attached patch add !importants — — Splinter Review 
Assignee: nobody → mstange
Status: NEW → ASSIGNED

        Attachment #498755 -
        Flags: review?(dao)

    
  

        Attachment #498755 -
        Flags: review?(dao) → review+

    
  

        Attachment #498755 -
        Flags: approval2.0?

    
    

    
  
Visual polish, blocking+a=beltzner
blocking2.0: ? → final+

        Attachment #498755 -
        Flags: approval2.0? → approval2.0+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/95782553234c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b9

    
    

    
  
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9pre) Gecko/20101225 Firefox/4.0b9pre ID:20101225030337

Markus, how likely is a new regression in this code? Would we have a need for a manual test on Litmus?
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: