620144 - clip paths and masks that can't be resolved should be ignored

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

currently we stop drawing if we fail to resolve a clip path or a mask. SVG 1.1 2nd edition changed so say that we should draw the object unclipped or unmasked.

Comment 1

[Robert Longson [:longsonr]]

http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectMiniApproved/masking-path-08-b.html
http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectMiniApproved/masking-path-10-b.html

Comment 2

[Robert Longson [:longsonr]]

Attachment: patch

Comment 3

[Jonathan Watt [:jwatt]]

Comment on attachment 498543 [details] [diff] [review]
patch

r=jwatt

>+	<rect x="0%" y="0%" width="100%" height="100%" fill="red"/>
>+	<rect x="0%" y="0%" width="100%" height="100%" fill="lime" clipPath="url(#null)"/>		

You don't need the x or y in your tests, if you can be bothered to remove them.

>      * @return the clip-path frame, or null if there is no clip-path frame
>      * @param aOK if a clip-path was specified but the designated element
>-     * does not exist or is an element of the wrong type, *aOK is set
>-     * to false. Otherwise *aOK is untouched.
>+     * is an element of the wrong type, *aOK is set to false.
>+     * Otherwise *aOK is untouched.

s/specified but the/specified and the/
s/is an element of the wrong type/exists but is an element of the wrong type/

>      * @return the mask frame, or null if there is no mask frame
>      * @param aOK if a mask was specified but the designated element
>-     * does not exist or is an element of the wrong type, *aOK is set
>-     * to false. Otherwise *aOK is untouched.
>+     * is an element of the wrong type, *aOK is set to false.
>+     * Otherwise *aOK is untouched.

same

Comment 4

[Robert Longson [:longsonr]]

Attachment: address review comments

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 498621 [details] [diff] [review]
address review comments

thanks

Comment 6

[Jonathan Watt [:jwatt]]

http://hg.mozilla.org/mozilla-central/rev/0ca1b65bb907