clip paths and masks that can't be resolved should be ignored

RESOLVED FIXED

Status

()

Core
SVG
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: longsonr, Assigned: longsonr)

Tracking

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
currently we stop drawing if we fail to resolve a clip path or a mask. SVG 1.1 2nd edition changed so say that we should draw the object unclipped or unmasked.
(Assignee)

Updated

7 years ago
Assignee: nobody → longsonr
(Assignee)

Comment 2

7 years ago
Created attachment 498543 [details] [diff] [review]
patch
Attachment #498543 - Flags: review?(jwatt)
Comment on attachment 498543 [details] [diff] [review]
patch

r=jwatt

>+	<rect x="0%" y="0%" width="100%" height="100%" fill="red"/>
>+	<rect x="0%" y="0%" width="100%" height="100%" fill="lime" clipPath="url(#null)"/>		

You don't need the x or y in your tests, if you can be bothered to remove them.

>      * @return the clip-path frame, or null if there is no clip-path frame
>      * @param aOK if a clip-path was specified but the designated element
>-     * does not exist or is an element of the wrong type, *aOK is set
>-     * to false. Otherwise *aOK is untouched.
>+     * is an element of the wrong type, *aOK is set to false.
>+     * Otherwise *aOK is untouched.

s/specified but the/specified and the/
s/is an element of the wrong type/exists but is an element of the wrong type/

>      * @return the mask frame, or null if there is no mask frame
>      * @param aOK if a mask was specified but the designated element
>-     * does not exist or is an element of the wrong type, *aOK is set
>-     * to false. Otherwise *aOK is untouched.
>+     * is an element of the wrong type, *aOK is set to false.
>+     * Otherwise *aOK is untouched.

same
Attachment #498543 - Flags: review?(jwatt) → review+
(Assignee)

Comment 4

7 years ago
Created attachment 498621 [details] [diff] [review]
address review comments
Attachment #498543 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Attachment #498621 - Flags: approval2.0?
Comment on attachment 498621 [details] [diff] [review]
address review comments

thanks
Attachment #498621 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/0ca1b65bb907
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
(Assignee)

Updated

7 years ago
Flags: in-testsuite+
Depends on: 679933
You need to log in before you can comment on or make changes to this bug.