Move pref "intl.collationKeyAsCodePoint" to chrome directory

VERIFIED FIXED in mozilla0.9

Status

P2
normal
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: ji, Assigned: nhottanscp)

Tracking

({l12y})

Trunk
mozilla0.9

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
We need this pref to be able to sort correctly on linux.
For 6.0, this is put in all.js in Japanese linux build.
(Assignee)

Comment 1

18 years ago
Yes, it has to be moved to .property file and need to change the related .cpp file.
Status: NEW → ASSIGNED

Comment 2

18 years ago
Is it navigator.properties, then?
(Assignee)

Comment 3

18 years ago
>Is it navigator.properties, then?

yes

Comment 4

18 years ago
adding intl
Keywords: intl
(Assignee)

Comment 5

18 years ago
intl -> l12y
Keywords: intl → l12y
OS: Linux → All
Priority: P3 → P2
Hardware: Other → All
(Assignee)

Comment 6

18 years ago
"intl.collationKeyAsCodePoint" is a bool pref. There is no
getLocalizedBoolPref() in nsIPref.
Tao, do you think we should create getLocalizedBoolPref()?
For this bug, I can change "intl.collationKeyAsCodePoint" to a char pref instead
of bool.

Comment 7

18 years ago
Alecf owns the getLocalizedXX() api. IMO, your proposal will work. No need to
add another api just for this particular bug.

Updated

18 years ago
Keywords: nsbeta1

Comment 8

18 years ago
Mass change of QA contact to ji for the bugs filed by her.
QA Contact: momoi → ji
(Assignee)

Updated

18 years ago
Target Milestone: --- → mozilla0.8
(Assignee)

Updated

18 years ago
Target Milestone: mozilla0.8 → mozilla0.9
(Assignee)

Comment 9

18 years ago
Created attachment 25969 [details] [diff] [review]
Patch, moved the pref to property

Comment 10

18 years ago
r=tao if the default value of this pref is null in navigator.properties

Comment 11

18 years ago
How about a slightly better wording, for understandability:

  mKeyAsCodePoint -> mUseCodePointOrder
  collationKeyAsCodePoint -> useCodePointOrder

Also, expand the comment in the property file to:

  valid collation options are: <empty string> or useCodePointOrder

sr=erik
(Assignee)

Comment 12

18 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Reporter)

Comment 13

18 years ago
With 04/10 build, in the file of .../locale/en-US/navigator/navigator.properties
I saw the pref of "intl.collationOption"
Naoki, did you change it to a char pref or bool pref?
(Assignee)

Comment 14

18 years ago
That's a char pref, the possible value are listed as in the file.

 29 # valid collation options are: <empty string> or useCodePointOrder
(Reporter)

Comment 15

18 years ago
Thanks. Verified as fixed.
Added Ying and Ray to cc list. We need this pref set to useCodePointOrder
for Japanese linux build.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.