Closed Bug 620169 Opened 9 years ago Closed 9 years ago

[@ SVGAnimatedLengthList::SetBaseValueString][@ SVGAnimatedNumberList::SetBaseValueString] useing domWrapper forgetting it might be null

Categories

(Core :: SVG, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, crash)

Crash Data

Attachments

(1 file, 1 obsolete file)

1.42 KB, patch
timeless
: review+
Details | Diff | Splinter Review
49 SVGAnimatedLengthList::SetBaseValueString(const nsAString& aValue)
57   DOMSVGAnimatedLengthList *domWrapper =
58     DOMSVGAnimatedLengthList::GetDOMWrapperIfExists(this);
59   if (domWrapper) {
65     domWrapper->InternalBaseValListWillChangeTo(newBaseValue);

72   rv = mBaseVal.CopyFrom(newBaseValue);
73   if (NS_FAILED(rv)) {
76     domWrapper->InternalBaseValListWillChangeTo(mBaseVal);
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498583 - Flags: review?(dholbert)
Attachment #498583 - Flags: approval2.0?
The same problem exists in SVGAnimatedNumberList, if you care to fix it there too.
Comment on attachment 498583 [details] [diff] [review]
patch

r=dholbert, but if it's not too much trouble, please also fix SVGAnimatedNumberList in the same push (or same patch even), as jwatt suggests.

(Many aspects of these files are in sync, so it's nice to fix both places simultaneously when a bug exists in both.)

(I also glanced at SVGAnimatedPointList.cpp and SVGAnimatedPathSegList.cpp, but it looks like they don't need this.)
Attachment #498583 - Flags: review?(dholbert) → review+
Summary: [@ SVGAnimatedLengthList::SetBaseValueString] uses domWrapper forgetting it might be null → [@ SVGAnimatedLengthList::SetBaseValueString][@ SVGAnimatedNumberList::SetBaseValueString] useing domWrapper forgetting it might be null
Attached patch handle bothSplinter Review
Attachment #498583 - Attachment is obsolete: true
Attachment #498705 - Flags: review+
Attachment #498705 - Flags: approval2.0?
Attachment #498583 - Flags: approval2.0?
http://hg.mozilla.org/mozilla-central/rev/37290bda896d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Crash Signature: [@ SVGAnimatedLengthList::SetBaseValueString] [@ SVGAnimatedNumberList::SetBaseValueString]
You need to log in before you can comment on or make changes to this bug.