If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

unreachable code in nsPlatformCharset::GetDefaultCharsetForLocale if HAVE_LANGINFO_CODESET

RESOLVED FIXED

Status

()

Core
Internationalization
--
trivial
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({coverity})

Trunk
All
Linux
coverity
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
119 nsPlatformCharset::GetDefaultCharsetForLocale(const nsAString& localeName, nsACString &oResult)

133 #if HAVE_LANGINFO_CODESET
155   return NS_SUCCESS_USING_FALLBACK_LOCALE;
156 #endif

this code isn't reachable #if HAVE_LANGINFO_CODESET, using #else would simplify compiler / analyzer / human parsing
162   nsAutoString localeStr(localeName);
169   return NS_SUCCESS_USING_FALLBACK_LOCALE;
(Assignee)

Comment 1

7 years ago
Created attachment 498678 [details] [diff] [review]
change #endif to #else
Assignee: smontagu → timeless
Status: NEW → ASSIGNED
Attachment #498678 - Flags: review?(smontagu)
Attachment #498678 - Flags: approval2.0?
Attachment #498678 - Flags: review?(smontagu) → review+

Updated

7 years ago
Attachment #498678 - Flags: approval2.0? → approval2.0+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/92258b02112b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.