Closed
Bug 620269
Opened 14 years ago
Closed 14 years ago
unreachable code in nsPlatformCharset::GetDefaultCharsetForLocale if HAVE_LANGINFO_CODESET
Categories
(Core :: Internationalization, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file)
|
939 bytes,
patch
|
smontagu
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
119 nsPlatformCharset::GetDefaultCharsetForLocale(const nsAString& localeName, nsACString &oResult) 133 #if HAVE_LANGINFO_CODESET 155 return NS_SUCCESS_USING_FALLBACK_LOCALE; 156 #endif this code isn't reachable #if HAVE_LANGINFO_CODESET, using #else would simplify compiler / analyzer / human parsing 162 nsAutoString localeStr(localeName); 169 return NS_SUCCESS_USING_FALLBACK_LOCALE;
Assignee: smontagu → timeless
Status: NEW → ASSIGNED
Attachment #498678 -
Flags: review?(smontagu)
Attachment #498678 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #498678 -
Flags: review?(smontagu) → review+
|
||
Updated•14 years ago
|
Attachment #498678 -
Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
|
||
Comment 2•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/92258b02112b
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•