Pref to disable flowed for display

VERIFIED FIXED

Status

MailNews Core
MIME
P3
normal
VERIFIED FIXED
17 years ago
10 years ago

People

(Reporter: BenB, Assigned: Daniel Bratell)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

17 years ago
Some users want to see the on-the-wire wrapping, even for format=flowed, i.e.
disable flowed, in the msg viewer. Make that possible.

Possible implementations (both effective only in the viewing case):
- Pref to add <br> after each source line
- Add <span class="moz-sourceline"> around each sourceline, which can then be
matched in a user stylesheet rule, e.g. |span.sourceline { display: block; }|.
That way is more generic -> elegant, but might cause odd behaviour on other
ends, e.g. copy&paste.
(Assignee)

Comment 1

17 years ago
The simple (even trivial) fix is to direct the mails to the normal text/plain 
decoder in the mime_find_class function.

What's a good name?
mailnews.disable_flowed_display maybe.

I won't do this the next couple of days (or maybe weeks) so if you find yourself 
unable to sleep feel free to make the patch.
(Reporter)

Comment 2

17 years ago
> The simple (even trivial) fix is to direct the mails to the normal text/plain
> decoder in the mime_find_class function.

No, this would also remove the advanced quoting info, which IMO should really be
preserved/used.

Adding a "<br>" at the right place is not really harder, is it? :)

> I won't do this the next couple of days (or maybe weeks) so if you find
> yourself unable to sleep feel free to make the patch.

hihi
(Assignee)

Comment 3

17 years ago
If someone is scared by format=flowed, than maybe they won't like the advanced 
quoting info too. 

I guess you filed this after reading the post in n.p.m.mailnews, and that one 
sounded like he didn't like it because he didn't understand it or because it 
didn't use to be that way.
(Reporter)

Comment 4

17 years ago
> I guess you filed this after reading the post in n.p.m.mailnews

Yes. (The one by Tillmann from anandtech.)

> sounded like he didn't like it because he didn't understand it or because it
> didn't use to be that way.

I guess it's the latter, but anyway, I think, he just wanted the old-style wrapping.

I don't know, if the plaintext converter would behave anyhow differently from
the flowed one. Your call.

Comment 5

17 years ago
I'd agree that disabling advanced quoting at the same time would probably be
desirable.  If I disable f=f it's probably because I want to see what a message
looks like in a more primitive mua, because I'm testing wrapping on mail send.
(It may display okay in mozilla's f=f, but what will other users see?)
Currently I have to use another mailer to test that.

I'd especially love having something in the View menu (or, failing that, in a
Debug menu) that let me toggle it on and off without having to restart, but
that's probably too much to ask since it's mostly useful as a developer's debug
feature.  (I wouldn't want to toggle it very often in everyday mail reading.)
(Reporter)

Comment 6

17 years ago
Seeing the recent discussion on .mail-news, I agree that offerint the option to
disable format=flowed completely is a good idea.
Summary: Pref to disable flowed for display. → Pref to disable flowed for display
(Assignee)

Comment 7

17 years ago
Created attachment 20795 [details] [diff] [review]
Patch to be able to disable the use of the format=flowed decoder.
(Assignee)

Comment 8

17 years ago
Created attachment 20796 [details] [diff] [review]
Same patch. diff -uw
(Assignee)

Comment 9

17 years ago
I'v introduced a new pref mailnews.display.disable_rfc_2646_support. The long
and windy name is intentional. I want users of the pref to be aware that they
are turning of a part of mailnews.

rhp or nhotta, can you review the change? It's about looking up a pref before
deciding whether to look for the format=flowed specifier.

Status: NEW → ASSIGNED
(Reporter)

Comment 10

17 years ago
Daniel, please indent the content of the new |if| block.
Patch is straight-forward.
(Assignee)

Comment 11

17 years ago
It is indented. I think you maybe looked at the diff -uw version I attached.
(Reporter)

Comment 12

17 years ago
ah, right. I wondered, what the -w was for again :).
Keywords: review

Comment 13

17 years ago
It's reasonable to let people know that they're turning off a feature of mail,
but can the pref please have the word "flowed" in it?  That's how people will
look for it, not by RFC number.  disable_flowed_support (or
disable_format_flowed_support if you're trying to make it long) would make it
much easier for users to find when they're looking for it.

Comment 14

17 years ago
Also, don't forget to initialize the pref in modules/libpref/src/init/all.js! 
We've had problems before because of people forgetting to initialize a pref,
then depending on its value later.
(Assignee)

Comment 15

17 years ago
Created attachment 20879 [details] [diff] [review]
New name of the pref and init in libpref/init/mailnews.js
(Assignee)

Comment 16

17 years ago
I wrote the code to cope with a missing pref, but it's better to have it there
anyway. You are right. I also renamed the pref. Now looking for a r.

Comment 17

17 years ago
r=nhotta

How did we disable format=flowed for CJK, I forgot, is there another pref for that?

Comment 18

17 years ago
okay, that was for sending, not for display.

Comment 19

17 years ago
looks ok to me, but shouldn't you get a review from rhp? he's the module owner
for the mime code.
(Reporter)

Comment 20

17 years ago
I thought, rhp was away? A month or so ago, when I sent him mail, an
autoresponder told me, that he won't read mail until mid Jan or so.
(Assignee)

Comment 21

17 years ago
Fix checked in. I hope it makes someone happy.

Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Updated

17 years ago
QA Contact: esther → pmock

Comment 22

16 years ago
Using build 20020429 on winxp and changing pref value to false for
(user_pref("mainews.send_plaintext_flowed", true); the content shows
Content-Type: text/plain; charset=us-ascii; format=flowed  instead of
Content-Type: text/plain; charset=us-ascii and the text did not flow,
Vefified
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.