620407 - JM: "Assertion failure: tpa == TPA_Error,"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

JSON.parse(function() {},
    function() {
        for (a = 0; a < 1; a++) {}
    }
)

asserts js debug shell on TM changeset 35697ebafa6c with -m and -j at Assertion failure: tpa == TPA_Error,

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

autoBisect shows this is probably related to bug 603044:

Due to skipped revisions, the first bad revision could be any of:
changeset:   55675:e000b5963fde
user:        David Anderson
date:        Fri Oct 15 11:36:56 2010 -0700
summary:     Remove JSOP_BEGIN and fix tracer integration issues (bug 603044, r=luke+dmandelin).

changeset:   55676:ae031ec5ad63
user:        David Anderson
date:        Mon Oct 18 20:30:36 2010 -0700
summary:     Build bustage fix.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

This bug is somewhere in json.cpp - it looks like parsing fails, setting cx->throwing in the process. But it gets revived in js_FinishJSONParse, which executes code with a pending exception already set.

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Resolving FIXED, the assertion no longer shows. After the changeset below landed, it now shows a message related to SyntaxError: JSON.parse

autoBisect shows this is probably related to the following changeset:

The first good revision is:
changeset:   62353:f569d49576bb
user:        Bill McCloskey
date:        Fri Feb 11 16:31:32 2011 -0800
summary:     Bug 631951 - Shrink methodjit memory usage by interpreting a few times before compiling (r=dvander)

Comment 4

[Jesse Ruderman]

Does the autoBisect result change if you use -a?

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Jesse Ruderman from comment #4)
> Does the autoBisect result change if you use -a?

Yes, it does, good point:

autoBisect shows this is probably related to the following changeset:

The first good revision is:
changeset:   67934:6c8becdd1574
user:        Jeff Walden
date:        Wed Mar 23 16:34:53 2011 -0700
summary:     Bug 589664 - Rewrite the JSON parser.  r=njn, anticipating more review but getting it in-tree now for simplicity, even if more changes need to be made later