Closed
Bug 620420
Opened 14 years ago
Closed 9 years ago
jsds_InvalidateAllEphemerals can use a do {} while() loop
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
766 bytes,
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
195 jsds_InvalidateAllEphemerals (LiveEphemeral **listHead)
196 {
since we dereference listHead here:
197 LiveEphemeral *lv_record =
198 reinterpret_cast<LiveEphemeral *>
199 (PR_NEXT_LINK(&(*listHead)->links));
we don't need to check *listHead the first time through the loop:
200 while (*listHead)
201 {
202 LiveEphemeral *next =
203 reinterpret_cast<LiveEphemeral *>
204 (PR_NEXT_LINK(&lv_record->links));
205 lv_record->value->Invalidate();
206 lv_record = next;
207 }
208 }
|
||
Updated•14 years ago
|
Attachment #498913 -
Flags: review?(brendan) → review+
Keywords: checkin-needed
Whiteboard: [push to tm]
|
||
Comment 2•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/6aea1d08ce37
Keywords: checkin-needed
Whiteboard: [push to tm] → fixed-in-tracemonkey
|
||
Updated•13 years ago
|
Component: JavaScript Debugging/Profiling APIs → JavaScript Engine
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6aea1d08ce37
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•