nsHTMLEditor::ParseCFHTML foolishly checks aStuffToPaste instead of *aStuffToPaste

RESOLVED FIXED in mozilla2.0b10

Status

()

defect
RESOLVED FIXED
9 years ago
Last year

People

(Reporter: timeless, Assigned: timeless)

Tracking

(Blocks 1 bug, {coverity})

Trunk
mozilla2.0b10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

9 years ago
1201 nsHTMLEditor::ParseCFHTML(nsCString & aCfhtml, PRUnichar **aStuffToPaste, PRUnichar **aCfcontext)

1263   *aStuffToPaste = nsLinebreakConverter::ConvertUnicharLineBreaks(fragUcs2Str.get(),

this should check *aStuffToPaste
1267   if (!aStuffToPaste)
Assignee

Comment 1

9 years ago
Posted patch patchSplinter Review
Attachment #498920 - Flags: review?(neil)
Attachment #498920 - Flags: approval2.0?
Assignee

Updated

9 years ago
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498920 - Flags: review?(neil) → review+

Comment 2

9 years ago
roc, I think this is safe to be considered for 2.0.
Assignee

Updated

9 years ago
Keywords: checkin-needed

Comment 3

9 years ago
Temporarily assigning to myself to make sure that I will land this.
Assignee: timeless → ehsan
Whiteboard: [needs landing]

Comment 4

9 years ago
http://hg.mozilla.org/mozilla-central/rev/0294914a8a45
Assignee: ehsan → timeless
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b10
You need to log in before you can comment on or make changes to this bug.