Closed Bug 620423 Opened 10 years ago Closed 10 years ago

nsHTMLEditor::ParseCFHTML foolishly checks aStuffToPaste instead of *aStuffToPaste

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b10

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(1 file)

1201 nsHTMLEditor::ParseCFHTML(nsCString & aCfhtml, PRUnichar **aStuffToPaste, PRUnichar **aCfcontext)

1263   *aStuffToPaste = nsLinebreakConverter::ConvertUnicharLineBreaks(fragUcs2Str.get(),

this should check *aStuffToPaste
1267   if (!aStuffToPaste)
Attached patch patchSplinter Review
Attachment #498920 - Flags: review?(neil)
Attachment #498920 - Flags: approval2.0?
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498920 - Flags: review?(neil) → review+
roc, I think this is safe to be considered for 2.0.
Keywords: checkin-needed
Temporarily assigning to myself to make sure that I will land this.
Assignee: timeless → ehsan
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/0294914a8a45
Assignee: ehsan → timeless
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b10
You need to log in before you can comment on or make changes to this bug.