Closed
Bug 620423
Opened 14 years ago
Closed 14 years ago
nsHTMLEditor::ParseCFHTML foolishly checks aStuffToPaste instead of *aStuffToPaste
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla2.0b10
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file)
|
844 bytes,
patch
|
neil
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
1201 nsHTMLEditor::ParseCFHTML(nsCString & aCfhtml, PRUnichar **aStuffToPaste, PRUnichar **aCfcontext)
1263 *aStuffToPaste = nsLinebreakConverter::ConvertUnicharLineBreaks(fragUcs2Str.get(),
this should check *aStuffToPaste
1267 if (!aStuffToPaste)
Attachment #498920 -
Flags: review?(neil)
Attachment #498920 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #498920 -
Flags: review?(neil) → review+
|
||
Comment 2•14 years ago
|
||
roc, I think this is safe to be considered for 2.0.
Attachment #498920 -
Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
|
|
||
Comment 3•14 years ago
|
||
Temporarily assigning to myself to make sure that I will land this.
Assignee: timeless → ehsan
Whiteboard: [needs landing]
|
|
||
Comment 4•14 years ago
|
||
Assignee: ehsan → timeless
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b10
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•