620430 - Passing empty string to sortby parameter causes 500

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect)

Description

[Paul Craciunoiu [:paulc]]

This does not happen with invalid input, just the empty string. Might be worth cleaning up the search form in general and using Django validation if possible.

Traceback (most recent call last):

  File "/data/www/support.mozilla.com/kitsune/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/support.mozilla.com/kitsune/apps/search/views.py", line 441, in search
    sortby = int(request.GET.get('sortby', 0))

ValueError: invalid literal for int() with base 10: ''

Comment 1

[Paul Craciunoiu [:paulc]]

https://github.com/jsocol/kitsune/commit/8fc6d3ab9d49f9fcbf5797632e30f70c4b7a7229

Comment 2

[Rebecca Billings [:rbillings]]

Verified all search forms do not generate traceback when submitting empty string.