Closed Bug 620434 Opened 9 years ago Closed 9 years ago

useless null check of result in nsXULTreeBuilder::ReplaceMatch

Categories

(Core :: XUL, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b12

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(1 file)

829 bytes, patch
enndeakin
: review+
beltzner
: approval2.0+
Details | Diff | Splinter Review
1152 nsXULTreeBuilder::ReplaceMatch(nsIXULTemplateResult* aOldResult,

null check:
1198     if (aNewMatch && aNewMatch->mResult) {
alias:
1202         nsIXULTemplateResult* result = aNewMatch->mResult;

use:
1205         nsresult rv = result->GetBindingFor(mRefVariable, ref);
use:
1259                     PRInt32 cmp = CompareResults((*parent)[index].mMatch->mResult, result);

useless null check:
1280             if (result && (result != mRootResult)) {
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498929 - Flags: review?(enndeakin)
Attachment #498929 - Flags: approval2.0?
Attachment #498929 - Flags: review?(enndeakin) → review+
Comment on attachment 498929 [details] [diff] [review]
patch

a=beltzner
Attachment #498929 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/8ec967e7457b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
You need to log in before you can comment on or make changes to this bug.