620508 - strike through on closed bugs

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect, P1)

Description

[Jeff Hammel]

For any bug id where the bug is closed, it should be displayed using
strike through.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

we can pull this status from a bugzilla query like we do for comments and when we get the results from the query, we can update the field.  This might require a handful of changes throughout the woo front end code.

Comment 2

[Mark Côté [:mcote]]

Attachment: Strike-through bug ids of resolved/closed bugs

Had to get a bit fancy here.  This was easy for just the bug-details tables, but due to the separation between the tables code and the graph code, it was a little more tricky to display strike-throughs in the tooltips on the Top Bugs page.

In order not to duplicate bugdetails calls, I made a single object responsible for grabbing and caching the results.  It uses callbacks to communicate the information back to the requesting parties.  If the same call is made twice, cached information is used.  Furthermore, bugs are loaded in batches of 50, which makes the table-loading a bit snappier.

The caching system doesn't last through page reloads; we could use persistent storage via globalStorage, but I don't think it's necessary.  Probably better to implement caching on the server side anyway, if we figure we need it.

Comment 3

[Mark Côté [:mcote]]

Attachment: Strike-through bug ids of resolved/closed bugs

This is a better patch, with per-request callbacks.

As discussed on IRC, I shouldn't have called this "a caching system"; rather, it's a central place from which we load bug information, to prevent redundant server calls if two different functions need data about the same bug (as with the Top Bugs graph and table functions).  Even if the data were cached on the server, the XHRs still take a second or two, which is unnecessary.  A server cache, if we deem it necessary, would complement, not replace, this system.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 510759 [details] [diff] [review]
Strike-through bug ids of resolved/closed bugs

this looks great.

Comment 5

[Mark Côté [:mcote]]

Pushed as http://hg.mozilla.org/automation/orangefactor/rev/b52773b0e1c0