62053 - too many entries cookperm.txt cause image functions to stop working

Status: RESOLVED DUPLICATE of bug 62057

(Core :: Graphics: Image Blocking, defect, P3)

Description

[Peter Janes]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.16-22 i686; en-US; m18) Gecko/20001205
BuildID:    2000120508

The cookie and image managers and 'View Image' will stop working as soon as a
numeric entry is added to cookperm.txt.  'View Image' gives a JavaScript error,
and the image and cookie managers have no entries.


Reproducible: Always
Steps to Reproduce:
1. Set up Mozilla to prompt for cookies and/or images.
2. Navigate to some sites to populate the cookperm.txt.
3. Open the cookie/image manager to see that there are entries displayed.
4. Navigate to an IP address or a site beginning with a number (e.g. 127.0.0.1)
that will load an image or set a cookie.  Alternately, exit Mozilla, and add '127.0.0.1	0F	0F'
(or any other address starting with a number) to the top of cookperm.txt.
5. Start Mozilla.
6. Open the cookie/image manager and note that cookies are shown, but not cookie
or image sites.
7. Close Mozilla and remove the numeric entry from cookperm.txt.
8. Start Mozilla, and open the cookie/image manager and note that the sites are
shown again.

Actual Results:  The cookie and image site lists are empty.  Also, if you choose
'View Image' from the browser's context menu, three JavaScript errors will be
reported on the console:

JavaScript error:
chrome://communicator/content/nsContextMenu.js line 532: permStr has no properties

JavaScript error:
 line 0: contextMenu has no properties

JavaScript error:
 line 0: contextMenu has no properties

Expected Results:  The cookie and image site lists should display the
appropriate entries from cookperm.txt.

Comment 1

[Mitchell Stoltz (not reading bugmail)]

->Cookies, I think.

Comment 2

[Stephen P. Morse]

I have the feeling that the reporter might have been confused by the symptoms 
that he reported.  Specifically, I don't think that the numeric entry had 
anything to do with it -- adding any entry would have had the same effect.

Turns out there is a hard-coded limit on the size of a buffer used in 
nsCookie.cpp.  See bug 62057.  I believe that this is what you were running 
into.

I'm currently working on a fix for that bug.

*** This bug has been marked as a duplicate of 62057 ***

Comment 3

[Peter Janes]

It definitely looked similar at the time, but seemed to behave differently.  My
original test was to remove all of the entries that were numeric, and the image
manager started working.  When I added a numeric entry, it stopped.  If I added
a text entry, the image manager still worked.

As long as the root cause has been discovered! 8^)

Comment 4

[Stephen P. Morse]

I tried it with a very small cookperm.txt file and added a numeric entry.  It 
did not present any problem.

I suspect that what was happening in your case was that the numeric entry and 
the non-numeric entry were of different sizes.  The problem is not on the number 
of total entries but on the number of total characters in all the entries.  So 
adding the non-numeric entry in your case might not have put you over the limit 
but adding the (probably longer) numberic entry did.