Closed Bug 620534 Opened 13 years ago Closed 13 years ago

Plugin-like files add overhead on every startup on Mac(nsPluginsDir::IsPluginFile is doing IO)

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking2.0 betaN+)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

References

Details

(Whiteboard: [ts])

Attachments

(1 file, 1 obsolete file)

fix+better naming
3.77 KB, patch
taras.mozilla
: review+
jaas
: approval2.0+
Details | Diff | Splinter Review 
      No description provided.
Whiteboard: [ts]
Attached patch fix (obsolete) — — Splinter Review 
This brings OSX inline with Windows/Linux behavior to not do redundant binary-groping. Saves about 600ms on my mac mini(10x speedup) since my Firefox is 64bit and most of the plugins are 32bit.
Attachment #499100 - Flags: review?(joshmoz)
Taras: looks like this should be assigned to you, hope you don't mind.
Assignee: nobody → tglek
Status: NEW → ASSIGNED
Comment on attachment 499100 [details] [diff] [review]
fix

Looks good to me but please capitalize the new function name. Also, "IsValidPlugin" and "IsPluginFile" in the same context is confusing. Make one of them more specific so they don't sound like the same thing.
Attachment #499100 - Flags: review?(joshmoz) → review+

        Attachment #499100 -
        Attachment is obsolete: true

        Attachment #499855 -
        Flags: review+

        Attachment #499855 -
        Flags: approval2.0?

    
  

        Attachment #499855 -
        Flags: approval2.0? → approval2.0+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/eaa44c83914f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

    
    

    
  
As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)
No longer blocks: 614423
blocking2.0: beta9+ → betaN+

    
  
Blocks: 614423

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.