Closed Bug 620535 Opened 9 years ago Closed 9 years ago

Mac nightly builds are failing

Categories

(Firefox for Android Graveyard :: General, defect)

x86
macOS
defect
Not set

Tracking

(fennec2.0b4+)

VERIFIED FIXED
Tracking Status
fennec 2.0b4+ ---

People

(Reporter: stechz, Assigned: mwu)

Details

Attachments

(2 files)

Since December 15.

http://tinderbox.mozilla.org/showlog.cgi?log=Mobile/1292835600.1292844238.28455.gz&fulltext=1

|Error: destination directory "../../dist/xpt" is not a directory or is not writeable.|
Assigning to mwu at his request.
Assignee: nobody → mwu
Attached patch FixSplinter Review
The packaging code wasn't finding the right directory with all our files on OSX. This is due to the wrong hard coding of _BINPATH, so this patch lets packager.mk set the _BINPATH correctly.

If this is ok, someone should check this in since I'll probably be gone in 6 hours for the next two weeks.
Attachment #499815 - Flags: review?(mark.finkle)
Comment on attachment 499815 [details] [diff] [review]
Fix

>diff --git a/installer/Makefile.in b/installer/Makefile.in

> 
> libs::
> 	find $(DIST)/bin/chrome -type f -name *.dtd -exec sed -i '/<!--.*-->/d' {} \;
> 	find $(DIST)/bin/chrome -type f -name *.dtd -exec sed -i '/<!--/,/-->/d' {} \;
> 	find $(DIST)/bin/chrome -type f -name *.properties -exec sed -i '/^#/d' {} \;
> 
>-include $(topsrcdir)/toolkit/mozapps/installer/packager.mk
>-

I have a feeling that moving the packager.mk include will render the the comment stripping code useless. I think I had to insert it before the packager.mk script for it to work. I can try to test it.
tracking-fennec: --- → ?
tracking-fennec: ? → 2.0b4+
Comment on attachment 499815 [details] [diff] [review]
Fix

r+ if we move the libs:: code too
Attachment #499815 - Flags: review?(mark.finkle) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/f6ff5d604bfb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified FIXED on build:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:2.0b9pre) Gecko/20110107 Firefox/4.0b9pre Fennec/4.0b4pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.