620638 - List of messages (central pane) recovering left-hand side panel

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jean-Bernard Marcon]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.2.13) Gecko/20101203 Ant.com Toolbar 2.1.0rc Firefox/3.6.13
Build Identifier: Mozilla/5.0 (X11; Linux i686; rv:2.0b9pre) Gecko/20101220 Thunderbird/3.3a2pre

See screenshot.


Reproducible: Always

Steps to Reproduce:
1. download shredder above-mentioned version. Install it on my /home. Profile is in a win directory (common to Ubuntu and win.
2. at first start, News from shredder are displaye in a tab (nothing special)
3. the other tab with my account has a twisted layout
Actual Results:  
Uneasy to read info from left pane

Expected Results:  
I would prefer something less messy :D

* Please note that I restarted in safe-mode and dis not encounter any problem with layout
-> I deleted every extension from the addon manager, then deleted everything in the extension folder from the profile and restarted, BUT I have still the messy layout

Comment 1

[Jean-Bernard Marcon]

Attachment: central pane recovering left-hand side one

Comment 2

[Jim Porter (:squib)]

Confirming this. The problem is that the minwidth of the folder pane is less than its actual minimum width.

Comment 3

[Richard Marti (:Paenglab)]

I'm seeing this also on Win7

Comment 4

[Jim Porter (:squib)]

Attachment: Let the folder description get cropped

This patch fixes the issue by allowing the folder view description to get cropped. I also increased the minwidth a bit, since 100px was entirely too small. I'm not sure there's an easy way to write a test for this, though.

Comment 5

[Jim Porter (:squib)]

Comment on attachment 499090 [details] [diff] [review]
Let the folder description get cropped

:Bienvenu, could you take a look at this?

Comment 6

[David :Bienvenu]

Comment on attachment 499090 [details] [diff] [review]
Let the folder description get cropped

Blake, do you mind looking at this review?

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 499090 [details] [diff] [review]
Let the folder description get cropped

So, I think I'm okay with this code.  I'm not entirely sure why you picked "125", but as long as Bryan likes how it works, I guess I'm okay with that.

Thanks,
Blake.

Comment 8

[Jim Porter (:squib)]

I just picked 125 since it seemed like enough for common folder names not to get truncated.

Looking into it a bit further, it seems that something between 3.1 and trunk changed; in 3.1, the pane collapsed once the pane's header wouldn't fit. In trunk, it kept shrinking until 100px, which caused strange behavior. Maybe this is actually a bug in core...

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #8)
> I just picked 125 since it seemed like enough for common folder names not to
> get truncated.
> 
> Looking into it a bit further, it seems that something between 3.1 and trunk
> changed; in 3.1, the pane collapsed once the pane's header wouldn't fit. In
> trunk, it kept shrinking until 100px, which caused strange behavior. Maybe this
> is actually a bug in core...

Yeah, shrunk further than minwidth this used to collapse.

Comment 10

[Jim Porter (:squib)]

(In reply to comment #9)
> Yeah, shrunk further than minwidth this used to collapse.

Technically, it still does this, but in the past the actual minimum width was determined by how much you could shrink the header instead of the minwidth attribute. In 3.1, once the renderer saw that it couldn't shrink the header anymore it just gave up and collapsed the pane. Now it keeps going until it hits the minwidth attribute value and causes chaos because it doesn't know how to shrink the header any further.

(You might already know all this, but I wanted to make sure everything was clear.)

Comment 11

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/6c894c03d3df

Comment 12

[Jim Porter (:squib)]

Should we check to make sure this isn't a bug in core? While the patch works for us, it could potentially bite other people too. Or maybe it was intentional, and this was just fallout.