620644 - Major changes of some English articles don't show up in localization dashboards, if the localized article has not been edited after migration

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect, P2)

Description

[Scoobidiver (away)]

Major changes on "Template:optionspreferences" don't show up in some localization dashboards. For instance, fr, it, pt-BR and ru locales are impacted.
It works well for some other locales as de, because there have been changes in this template after SUMO migration.

Comment 1

[Scoobidiver (away)]

It is also applicable to changes of "What is Firefox Sync?" article.

Comment 2

[Scoobidiver (away)]

It is also applicable to changes of "Contributor Home page" article.

Comment 3

[Kadir Topal [:atopal]]

James, could you have a look at this? Not being able to follow changes of English articles is a major issues.

Comment 4

[James Socol [:jsocol, :james]]

Added to 2.4.2 too close to freeze. Will dig into it next week for 2.4.3.

Erik, my suspicion is that the queries in the l10n dashboard don't find revisions that are current but have no approved value. Maybe it's easiest to just set is_approved = True where id in (select current_revision_id from documents)?

Comment 5

[Erik Rose [:erik][:erikrose]]

Well, in my few-week-old dump, there are no current revisions that aren't approved.

Comment 6

[Erik Rose [:erik][:erikrose]]

It doesn't look like we set based_on_ids for the articles we migrated. If we only migrated 1 revision of the English articles we migrated (which I think is the case), we should just run a migration to set the based_on_ids of the translations to the first revision of the originals.

Comment 7

[Kadir Topal [:atopal]]

Hey guys, this is a big one, is there a way to get it into the next release after 2.4.3?

Comment 8

[Paul Craciunoiu [:paulc]]

If what Erik says in comment 6 still applies and fixes it, I should be able to get a migration SQL going for these.

Comment 9

[Erik Rose [:erik][:erikrose]]

Fixed in https://github.com/jsocol/kitsune/commit/d4b83320d79abf815137ef5a3d5984189e9ba11c.

Comment 10

[Rebecca Billings [:rbillings]]

Is there a migrated article I can verify, or is there a way to have a test article migrated?

Comment 11

[Erik Rose [:erik][:erikrose]]

Either of the two Scoobidiver mentioned above should be fine. Make a change to either of those, review it and mark it as substantial, and then confirm it shows up on the L10n Dashboard.

Comment 12

[Rebecca Billings [:rbillings]]

Verified approved major edits to an en-US article display under Traductions obsolètes on the /fr locale.

Comment 13

[Scoobidiver (away)]

Don't verify in the French locale as I have already edited articles based on the KB articles forum, even if they didn't show up in the localization dashboard. So that is normal it works even without the fixing.

Comment 14

[Rebecca Billings [:rbillings]]

This was also tested in the /de locale