620678 - Support for Ahead of Time Compilation of ABC

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, enhancement)

Description

[Alex Macdonald]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_5; en-us) AppleWebKit/533.19.4 (KHTML, like Gecko) Version/5.0.3 Safari/533.19.4
Build Identifier: 

This patchset includes changes and additions to the VM necessary to support the AOT compiler. configuring a tamarin build with "--enable-aot" allows you to build the vm and the aot support libraries with all the aot-related ifdefs enabled. The AOT compiler used to compile ABC to LLVM bitcode currently remains closed-source.

The documentation is still being written but you can see the current state in the patch (doc/aot.txt)

Reproducible: Always

Comment 1

[Alex Macdonald]

Attachment: AOT support

Comment 2

[Alex Macdonald]

Attachment: AOT Support

rebase to take into account changes to ArrayObject + improved the documentation

Comment 3

[Alex Macdonald]

Attachment: AOT Support

rebased to take into account recent changes in redux and in FRMain

Comment 4

[Steven Johnson]

Comment on attachment 508673 [details] [diff] [review]
AOT Support

This patch includes the aot directory, which currently isn't in tamarin-redux. Did you mean to include it?

Comment 5

[Alex Macdonald]

(In reply to comment #4)
> Comment on attachment 508673 [details] [diff] [review]
> AOT Support
> 
> This patch includes the aot directory, which currently isn't in tamarin-redux.
> Did you mean to include it?

Yep, this change open sources all the AOT code and allows you to build with the AOT ifdefs enabled from the open source repo (./configure --enable-shell --enable-aot)

Comment 6

[Steven Johnson]

Comment on attachment 508673 [details] [diff] [review]
AOT Support

The whole "aot" directory is new -- is it going to live here in TR now? (if so, good, just need to confirm)

ArrayObject.h redeclares isSimpleDense(), which is gone for good -- I assume this is an inadvertent mistake. 

Otherwise I see no red flags.

Comment 7

[Alex Macdonald]

(In reply to comment #6)
> Comment on attachment 508673 [details] [diff] [review]
> AOT Support
> 
> The whole "aot" directory is new -- is it going to live here in TR now? (if so,
> good, just need to confirm)

Yeah, it's all open now. Let me know if you want it in the aot directory or if you want it in core, I don't mind where it lives.
 
> ArrayObject.h redeclares isSimpleDense(), which is gone for good -- I assume
> this is an inadvertent mistake. 

Oh yeah, that's a mistake, ArrayObject.cpp shouldn't actually have any need for that any more
 
> Otherwise I see no red flags.

Comment 8

[Steven Johnson]

> Yeah, it's all open now. Let me know if you want it in the aot directory or if
> you want it in core, I don't mind where it lives.

Woot! Let's leave it in aot for now.

Comment 9

[Tamarin Bot]

changeset: 5862:beab42b6a30e
user:      Steven Johnson <[e-mail]>
summary:   Bug 620678 - Support for Ahead of Time Compilation of ABC (r=stejohns)

http://hg.mozilla.org/tamarin-redux/rev/beab42b6a30e

Comment 10

[Steven Johnson]

I'm pushing this in anticipation of R+ from other reviewers (who are currently timezone/weather-challenged) in order to get some internal merges going; obviously we'll fix/back out if objections are raised.

TR 5862:beab42b6a30e

Comment 11

[Lars T Hansen]

Comment on attachment 508673 [details] [diff] [review]
AOT Support

I did not look carefully at the stuff in aot/ but the other diffs look fine.

Comment 12

[Edwin Smith]

Comment on attachment 508673 [details] [diff] [review]
AOT Support

Could we open a bug for the remaining documentation work implied in the doc?

> Domains
> - explain why we punted on this and what we might do in the future

> Performance
> - point out areas where we beat the jit, and where we need improvement

A list of bullets would be great, a few open bugs would be even better.