620796 - Bugzilla::Migrate->create_legal_values chokes trying to create components

Status: RESOLVED FIXED

(Bugzilla :: Bug Import/Export & Moving, defect)

Description

[Eevee (Evelyn Woods) [:eevee]]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b9pre) Gecko/20101221 Firefox-4.0/4.0b9pre
Build Identifier: 3.7.3

create_legal_values attempts to create missing values for every Bugzilla choice field, by using:

Bugzilla::Field::Choice->type($field)->new({ name => $value });

But this call doesn't work for components; they require both a name and a product.  Thus migrate.pl promptly chokes and dies at this step.

Teeny backtrace:
Bad argument product sent to Bugzilla::Component::new function.
 at Bugzilla/Component.pm line 86
        Bugzilla::Component::new(...) called at Bugzilla/Migrate.pm line 645
        Bugzilla::Migrate::create_legal_values(...) called at Bugzilla/Migrate.pm line 184
        Bugzilla::Migrate::do_migration(...) called at ./migrate.pl line 53

Reproducible: Always

Comment 1

[Max Kanat-Alexander]

Attachment: v1

This should fix it. Can you confirm that this fixes it? Then I'll check it in to the 4.0 branch and trunk. (I'm granting myself review as the module owner for Migrate.)

Comment 2

[Eevee (Evelyn Woods) [:eevee]]

Yep, works now.  (And then crashes *later*, but it's an improvement!)

Comment 3

[Max Kanat-Alexander]

Great, thanks!

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/Migrate.pm
Committed revision 7631.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/                         
modified Bugzilla/Migrate.pm
Committed revision 7499.