Closed Bug 620851 Opened 9 years ago Closed 9 years ago

Change Android branded release builds shared ID

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set

Tracking

(fennec2.0b4+)

VERIFIED FIXED
Tracking Status
fennec 2.0b4+ ---

People

(Reporter: pavlov, Assigned: blassey)

References

Details

(Whiteboard: [4.0b3])

Attachments

(1 file)

So that you can have fennec and firefox on at the same time.
Attached patch patchSplinter Review
Assignee: nobody → blassey.bugs
Attachment #499214 - Flags: review?(mwu)
Comment on attachment 499214 [details] [diff] [review]
patch

r+ for branch only. Need to figure out what we want to do with SUT to really fix this. Alternately, we could make this conditional on having a branded build somehow but that's not important if we're only landing on branch right now.
Attachment #499214 - Flags: review?(mwu) → review+
tracking-fennec: --- → ?
OS: All → Android
Whiteboard: [4.0b3]
Why does the shared ID need to change? I'm missing something here.
(In reply to comment #3)
> Why does the shared ID need to change? I'm missing something here.

To the best of my knowledge, we changed the app id from org.mozilla.fennec -> org.mozilla.firefox for release builds (nightlies did not change). Now, it's possible to install a nightly and a release on the same phone. However, we were getting errors when trying to do that because the shared ids were the same on the nightly and release installs.

We fixed that by changing the shared id, but now we need figure out a way to get SUT to work with either shared id.
OK, I think I understand. I think it is because the shared id is the same but the key is different. It requires both. I'll see if I can figure out what to do about this on the agent side.
What is the status on this?
Is it a requirement that you have the SUTAgentAndroid installed when you have both fennec and firefox mobile installed on Android?

If it is not, just uninstall SUTAgentAndroid and you should be good to go.

Otherwise, I need to understand the desired usage. I've got some redesign work to do if we really need to have fennec, firefox and the agent all installed and running at the same time.
I don't think we need them all installed at the same time, but I think we want to test both SUT + Fennec, as well as SUT + Firefox, on the same device pool at some point.
Do the rest of the folks on this bug agree with Aki? If so this is a build time issue and can probably be solved fairly easily. If not, please chime in so I can figure out how to make this possible.
tracking-fennec: ? → 2.0b4+
any update here?
Bob can update here with more details, but we have a way to run one agent that will work with both Firefox and Fennec branded builds.  We are completing the finishing touches on that now, and should have it out for testing later this week or early next.  The changes will not affect any upstream components (i.e. no changes required to devicemanager, buildbot scripts etc).
So what we are doing is;

1) Creating ContentProvider's that will have the corresponding sharedid and signing keys with Fennec and Firefox. Which will allow each to handle the functionality that requires the sharedid's and keys. This is requiring a fair amount of refactoring to shoehorn in the CR interface code.

2) Removing the sharedid and key from SUTAgentAndroid itself thereby allowing it to handle either or both. This way we will not need to replace the Agent based upon which browser you want to control. It also keeps the framework from requiring a bunch of refactoring since the IPAddr/Port pairs aren't changing.

Adding yet another one down the road (Tablet maybe) will be as simple as creating a new ContentProvider and some really small tweaks to the agent in the worse case.
The tasks in comment 12 have been done, and the code is being tested. Assuming no issues we will check-in and work with releng to get it deployed (it's backwards compatible so we should be able to deploy with no changes to the rest of the infrastructure). Once this is done you guys can check in your changes and nothing should be broken.
What is the status of this?  This needs to land today for code freeze.
I gave blassey the go ahead on irc yesterday. Aki has the new agents and helpers he needs to deploy into the environments. These need to happen together so that there is as little disturbance as possible. The old agent isn't compatible with the new browsers and the new agent isn't compatible with old browsers due to the sharedid stuff. Things will get noisy while these changes are taking hold, but then should settle down nicely.
pushed http://hg.mozilla.org/mozilla-central/rev/7d2c1fef16f3
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Depends on: 627695
Depends on: 629369
VERIFIED FIXED on:

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110526 Firefox/7.0a1 Fennec/7.0a1 

Device: HTC Desire Z (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.