620868 - Better error message for invalid version message from validator

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Jeff Balogh (:jbalogh)]

Invalid version number error messages should be more useful than they are and say explicitly which version and application name is affected and give a link to the allowed versions at /pages/appversions.

Comment 1

[Kumar McMillan [:kumar]]

Attachment: addon with invalid fennec version

Comment 2

[Kumar McMillan [:kumar]]

STR:
- validate attached add-on

you see:

Invalid maximum version number

Error: The maximum version that was specified is not an acceptable version number for the Mozilla product that it corresponds with.

Error: Version "2.0b1pre" isn't compatible with {a23983c0-fd0e-11dc-95ff-0800200c9a66}.


This is best fixed in amo-validator itself, in testcases/targetapplication.py.  Instead of guid, the application name should be displayed.  And as mentioned, a link to https://addons.mozilla.org/en-US/firefox/pages/appversions/

Comment 3

[Matt Basta [:basta]]

Fixed:

https://github.com/mattbasta/amo-validator/commit/dbd8cfbbf26dadde59d33990a789209389d3bda6

If the GUID is a recognized Mozilla application, it will display the friendly name instead of the GUID.

Comment 4

[Kumar McMillan [:kumar]]

This has been pushed to Zamboni.  I don't see a link to https://addons.mozilla.org/pages/appversions/ but the error message reads a lot nicer.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Invalid maximum version number

Error: The maximum version that was specified is not an acceptable version number for the Mozilla product that it corresponds with.

Error: Version "2.0b1pre" isn't compatible with "fennec".

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.