No success message on saving changes

VERIFIED FIXED in 5.12.6

Status

addons.mozilla.org Graveyard
Developer Pages
VERIFIED FIXED
7 years ago
2 years ago

People

(Reporter: krupa, Assigned: jbalogh)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
[from the etherpad]

No success message on saving. We should use new (collections) notification styles for this.
(Reporter)

Comment 1

7 years ago
https://github.com/jbalogh/zamboni/commit/54d8ae789
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

7 years ago
No success message on changing values on:

* edit page
* manage versions page
* dev-profile page
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 3

7 years ago
(In reply to comment #2)
> No success message on changing values on:
> * edit page

chowse: This is the ajax-edit page.  Should there be any message? Where would it go?
(Assignee)

Comment 4

7 years ago
(In reply to comment #2)
> No success message on changing values on:
> * manage versions page
> * dev-profile page

http://github.com/jbalogh/zamboni/commit/9eef9c1

cc'ing chowse for comment 3.
Status: REOPENED → NEW
On save, I'd add a badge that appears beside the header for 2 secs, fades out in 1 sec, then is removed. Here's some style for the badge:

.save-badge {
    background: #41B300;
    border-radius: 1em;
    color: #fff;
    font-family: helvetica, arial, sans-serif;
    font-size: 10px;
    font-style: normal;
    font-weight: bold;
    margin-left: 0.5em;
    padding: 0.375em 1em;
}
Created attachment 500076 [details]
Screenshot of Save Badge
(Assignee)

Comment 7

7 years ago
edit page: http://github.com/jbalogh/zamboni/commit/d6f5745

Thanks chowse!
Status: NEW → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

7 years ago
verified  that there are success  messages on change @

* edit page
* manage versions page
* dev-profile page
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.