Closed
Bug 620907
Opened 14 years ago
Closed 14 years ago
js/src/build/unix is missing print-failed-commands.sh
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
Details
Attachments
(1 file)
|
361 bytes,
patch
|
khuey
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
timeless-mbp:mozilla-central timeless$ grep -C1 print-failed js/src/config/rules.mk
ifneq (,$(findstring -s,$(MAKEFLAGS)))
ELOG := $(EXEC) sh $(BUILD_TOOLS)/print-failed-commands.sh
else
The fact that the script is missing hasn't been a problem because the rule to set ELOG wasn't working, but bug 620905 will fix that.
this is technically a bustage fix even without the fix for bug 620905 -- there's probably some case where make actually could trigger this missing script.
Assignee: general → timeless
Status: NEW → ASSIGNED
Attachment #499263 -
Flags: review?(ted.mielczarek)
Attachment #499263 -
Flags: approval2.0?
|
||
Comment 2•14 years ago
|
||
technically still build-config, so moving component, keeping the QA watch on as a CC though.
Component: JavaScript Engine → Build Config
QA Contact: general → build-config
Attachment #499263 -
Flags: review?(ted.mielczarek) → review+
|
||
Updated•14 years ago
|
Attachment #499263 -
Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
|
||
Comment 3•14 years ago
|
||
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•