Closed Bug 620988 Opened 11 years ago Closed 11 years ago

preferences code uses getFolderContents but never closes the container.

Categories

(Firefox :: Preferences, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0b9

People

(Reporter: mak, Assigned: mak)

Details

Attachments

(1 file)

Gavin found this, we should fix it, open containers are expensive due to observers.

http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/selectBookmark.js#97
Attached patch patch v1.0Splinter Review
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #499323 - Flags: review?(gavin.sharp)
Attachment #499323 - Flags: approval2.0?
Attachment #499323 - Flags: review?(gavin.sharp)
Attachment #499323 - Flags: review+
Attachment #499323 - Flags: approval2.0?
Attachment #499323 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/2ab02651a773
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b9
You need to log in before you can comment on or make changes to this bug.